From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754777AbdBPAIh (ORCPT ); Wed, 15 Feb 2017 19:08:37 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:53697 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753360AbdBOXQV (ORCPT ); Wed, 15 Feb 2017 18:16:21 -0500 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Steve French" , "Sachin Prabhu" Date: Wed, 15 Feb 2017 22:41:40 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 120/306] Cleanup missing frees on some ioctls In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.40-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Steve French commit 24df1483c272c99ed88b0cba135d0e1dfdee3930 upstream. Cleanup some missing mem frees on some cifs ioctls, and clarify others to make more obvious that no data is returned. Signed-off-by: Steve French Acked-by: Sachin Prabhu [bwh: Backported to 3.16: - Drop changes to smb2_duplicate_extents(), smb3_set_integrity() - Adjust context] Signed-off-by: Ben Hutchings --- --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -228,7 +228,7 @@ SMB3_request_interfaces(const unsigned i le64_to_cpu(out_buf->LinkSpeed)); } else cifs_dbg(VFS, "error %d on ioctl to get interface list\n", rc); - + kfree(out_buf); return rc; } #endif /* STATS2 */ @@ -640,6 +640,7 @@ smb2_clone_range(const unsigned int xid, cchunk_out: kfree(pcchunk); + kfree(retbuf); return rc; }