From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756215AbdKGB2a (ORCPT ); Mon, 6 Nov 2017 20:28:30 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:51556 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbdKFXXd (ORCPT ); Mon, 6 Nov 2017 18:23:33 -0500 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org Date: Mon, 06 Nov 2017 23:03:07 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.2 135/147] mct_u232: Fix use of uninitialized pointer in mct_u323_startup() In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.2.95-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Ben Hutchings My backport of commit 4e9a0b05257f "USB: mct_u232: add sanity checking in probe" incorrectly added a dev_err() call using port->dev before 'port' was initialised. Use the 'serial' parameter to look up the device instead. Signed-off-by: Ben Hutchings --- --- a/drivers/usb/serial/mct_u232.c +++ b/drivers/usb/serial/mct_u232.c @@ -449,7 +449,7 @@ static int mct_u232_startup(struct usb_s /* check first to simplify error handling */ if (!serial->port[1] || !serial->port[1]->interrupt_in_urb) { - dev_err(&port->dev, "expected endpoint missing\n"); + dev_err(&serial->dev->dev, "expected endpoint missing\n"); return -ENODEV; }