From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELuBLRwulE97y88txRZc6rpPt7pfn1OEuK8wqzPEZ4QefYEDlaE50Qn+Af4H+3C81ALerhtl ARC-Seal: i=1; a=rsa-sha256; t=1520824102; cv=none; d=google.com; s=arc-20160816; b=a0IJHLyJfwfEbHOq7GNI4aWEW48SDSLIXkhLfVlGxaIjSFo9PR+WmQnhC16+VffpSQ Y9hyXnG+9kvQCvYHFQ/2qvVcTfU7N6VXYkPD/Y1rXf+bQ2mBMzgUHWi3qQSLqbakSnlI MBLnxbGzBbFe/tOUW+/bRvF6yJmpVBk9hjBSHvH5x07PXHZYCaVbGQUsEtZxBOZYAOfI K+Sc2Ds3oF2ByvXL0mmXNmv95Bv2LM7u2f8KlA9yioiI7q03tQDIfdoYyPx44NXcSNL9 TUMKDbmNh/KxJVJe9GnLKw6DE2cLa3tx1bs9bvzyicKGymQ78nSZvmxddsq/fF3QcpIV 2ucQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:subject:message-id:date:cc:to:from:mime-version :content-transfer-encoding:content-disposition :arc-authentication-results; bh=GEYwXdDxBuK3hJhpxyCGOiX9Av0F6a4cMpGdkr6u0Hg=; b=JOe+UHAaKpL4FMp3QI/U5HUsO/QF3BK1PV0giXKmbbH1y2lU3D+MIITGWW6WGTQ3Kn IGzSCtu76gUXYMDX6AWBsRpIYA203GSMkJC3gqLqxrxCkLMgQ5zd4v0GN3TcgbnH7fZz QPbQEfOj6W7sE2+CehvTsjQi9I9he4bBFyIWVJtyZ8BTY/AeQ1UO/GX2ENCG2bctnVgJ Vkq+nsSq9fjW7uW9Gw3LFc8ppENvmRbKAqs5M5Ajp0k2ddYVEdA7Krv4HA1inioYRYf2 JHJiX5c7qZiBu75iX0ex0rZW0zkzf1y8ePZiNbLe6zmb+1A+sc46Rsdve8KaW2aojr5f MJfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of ben@decadent.org.uk designates 88.96.1.126 as permitted sender) smtp.mailfrom=ben@decadent.org.uk Authentication-Results: mx.google.com; spf=pass (google.com: domain of ben@decadent.org.uk designates 88.96.1.126 as permitted sender) smtp.mailfrom=ben@decadent.org.uk Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Greg Kroah-Hartman" , "Jiri Kosina" , "Tom Lendacky" , "Thomas Gleixner" , "Peter Zijlstra" , "Josh Poimboeuf" , "Paul Turner" , "Arjan van de Ven" , "Dave Hansen" , "Kees Cook" , "David Woodhouse" , "Jeff Law" , "Andy Lutomirski" , "Waiman Long" , "Tim Chen" , "Andi Kleen" , "Linus Torvalds" Date: Mon, 12 Mar 2018 03:06:12 +0000 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 43/76] x86/retpoline: Remove the esp/rsp thunk In-Reply-To: X-SA-Exim-Connect-IP: 2a02:8011:400e:2:6f00:88c8:c921:d332 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1594699653695967264?= X-GMAIL-MSGID: =?utf-8?q?1594699653695967264?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 3.16.56-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Waiman Long commit 1df37383a8aeabb9b418698f0bcdffea01f4b1b2 upstream. It doesn't make sense to have an indirect call thunk with esp/rsp as retpoline code won't work correctly with the stack pointer register. Removing it will help compiler writers to catch error in case such a thunk call is emitted incorrectly. Fixes: 76b043848fd2 ("x86/retpoline: Add initial retpoline support") Suggested-by: Jeff Law Signed-off-by: Waiman Long Signed-off-by: Thomas Gleixner Acked-by: David Woodhouse Cc: Tom Lendacky Cc: Kees Cook Cc: Andi Kleen Cc: Tim Chen Cc: Peter Zijlstra Cc: Linus Torvalds Cc: Jiri Kosina Cc: Andy Lutomirski Cc: Dave Hansen Cc: Josh Poimboeuf Cc: Arjan van de Ven Cc: Greg Kroah-Hartman Cc: Paul Turner Link: https://lkml.kernel.org/r/1516658974-27852-1-git-send-email-longman@redhat.com [bwh: Backported to 3.16: adjust filename] Signed-off-by: Ben Hutchings --- arch/x86/lib/retpoline-export.c | 1 - arch/x86/lib/retpoline.S | 1 - 2 files changed, 2 deletions(-) --- a/arch/x86/lib/retpoline-export.c +++ b/arch/x86/lib/retpoline-export.c @@ -21,5 +21,4 @@ INDIRECT_THUNK(dx) INDIRECT_THUNK(si) INDIRECT_THUNK(di) INDIRECT_THUNK(bp) -INDIRECT_THUNK(sp) #endif /* CONFIG_RETPOLINE */ --- a/arch/x86/lib/retpoline.S +++ b/arch/x86/lib/retpoline.S @@ -35,7 +35,6 @@ GENERATE_THUNK(_ASM_DX) GENERATE_THUNK(_ASM_SI) GENERATE_THUNK(_ASM_DI) GENERATE_THUNK(_ASM_BP) -GENERATE_THUNK(_ASM_SP) #ifdef CONFIG_64BIT GENERATE_THUNK(r8) GENERATE_THUNK(r9)