From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D4C41A780 for ; Tue, 7 Jul 2026 13:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431185; cv=none; b=WnGbmG9vTs8yGn/+kc7n3ku5YNSzTu1vwtWOsFZIj0LT3THYhnqB4ju6BdgPWVUJGXmlAFN03c6eGwDSDOfcJnjmJjV/oRAfhIZIi/z7Ak1qFC5QoZEZ6IrWPto3P8DT2YpYQ35fdW92WnzsNXKcnuHDw3KcejiyPHrgvWsFB88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431185; c=relaxed/simple; bh=QW66NHVTI6Oj4WQFVixJ8XidASn4HkchNXi+aEftbi8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DKrgjAmygSTgqrmLGlpJ100rC1+RgaKYW0hK31ydBIwTqsrWQSX501DVSc+HPAhEh14C39O6XmHzwVKDaZOewe68HIc3sA7hKSZBkA8JmFdT0elfyKTCpjEjGDKWhzISevoRr5sCN73d8AQSm0oZYpks9ZsVYAbE2nv1xeUNvr8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=klrc312T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZT3Pok1R; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="klrc312T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZT3Pok1R" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667C8epC3606087 for ; Tue, 7 Jul 2026 13:33:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tFefM7BuRRk3FDn8aw0Ky5+cc0k1y191ixtbbp19Gbs=; b=klrc312TR6JIkbNg Kvp30MhZqDGDUr6Cok7o00LHV3rlEZC9UCRzbvKZrZydQftcN7J0BsOrtuH57MJ8 HahYCLaEYo3j7595ExWHyVzujZs0fQ+TkEhESevi0vJcAe6mcYy/WcwuyWKrVCSa 0uSYlbu2RBb0a6Y0B6athDDTcjuir1E2J5Trehoq+CcvAXOBdCMZ/RuPievSJ4Vd V512xfl2j6L78TLo/zB9WEHo18yFvz+cZaU+l8YNmI1MfstyWlMOal3pQsXTspob Ox67rUaZywidb7qehmxNKj3aiBAuI+tp9546cHbUEQl/SMSw0YVesCTCIf9jJfVJ TV4Bmg== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8sm8j726-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 13:33:03 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-7377e2f1a62so1330029137.2 for ; Tue, 07 Jul 2026 06:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783431183; x=1784035983; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tFefM7BuRRk3FDn8aw0Ky5+cc0k1y191ixtbbp19Gbs=; b=ZT3Pok1R63GBz4eHdlAN8+7z6foeSWqfuDeWBJ4cWKrfJ4OdI6sOXtj7Hkujd+PAQi UoH5xxi1Sfqb/sbHuTh3nwgw970AIpfYDyaQczLjKe6mAONBb5v6scUJ2mEcaDprNCXi Fh4iY0pRvSxDJFpKrCfmeluecZekVDkZHNZRUyK+5SgIUEYIDxLdyvCeDQTVId0uB5rx flzZWFTa/kXDHaYpVl18SygEaXKgXV42gmWQeYcxhVpQ48K4BYGtMoodyZlCy4uI9FQ5 q6gTjkZLDJfJmiSwtMk3ZYurW6lCZ/lvTrMFfCll6f/+gIGlW6Kqatseu/35DuMZVtDR 2fEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783431183; x=1784035983; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=tFefM7BuRRk3FDn8aw0Ky5+cc0k1y191ixtbbp19Gbs=; b=b31xynxJirUWzMTulbcgJKFCkkjRnOoc+wbdNLtkT2nUz8MBbSd6GeZNdTj30wLxgJ FmE6JwP7iFE4TF/FLHHv72+AVLgcG3dU2ZzcBvoo7iQLZeEABeF+8E3ksVsMWjmwC/SU DxWDSx1IOstHKSOvqwMp7+c5OylZv4W9UtfwYe0Voue6pPcDuDvkkK/mM9xh4Z24cLw/ W6eUP9PFj5XmG2PRI4nxwoPENjRneHwq+50tNYzzKaLKH5RALDiCgrdDfkycKzFetqF3 FmJjKKS0wxJ66Xavt0QhpZb9YB/P9xD3Ef9tI6Ulsc6iJJwNnLdO/vDYRAD86ly0TgCL TE6g== X-Forwarded-Encrypted: i=1; AHgh+RoCwpwTOCQFpkN29EqPG/+T5iQANwVNDIeyojmbkxjwnIGmqzOcefaw5t6yoOZ5+FebfdWE/HoGdIGonc4=@vger.kernel.org X-Gm-Message-State: AOJu0YzovCTl7F6GQa7KIMwEIilwLlOqEB5qS1ISkm4Yneq2u8XXQK8i qdVIpHKuhZ9EH43tM+0sgZ44N1vD43qkgIlyzY3Sh++ACmJHuFQ7PYGQYi7mwIntnL2BpEbc8a9 5E1RgQkmjtDo1JIntREPoVPwE3AOGdpCtap6aAdQdA01yxkN+5kxvK5rbxYcVWxjarwCxk/Bqs+ w= X-Gm-Gg: AfdE7cktptTt4UTmxiNkytAhea1jHLySZLKQeq2Z1407+caiEKYg7d5kS87rHUsWZjE QsdJ/x831MTREuohcemV014s7HHHLD7av+k459CKdRi7WtwY3ZBm6pM7yHpdFTzrZRvFLwJk4gd yIp+Cu4XkR7W8v/Yw32HiJPLLm4Pjhxsx2BvdXTpAg4qGtFMaPxVHm0M3FyBXAMn13n8NeDXsTX 3U3hNtsHPYNfchb8kn/blzs6hi56NYjrhiyp4DdWUbqxuh5hhQN/TLhuyvFtoNixXkIAfcwEpZv kP1rDWqQKWGJHxYe8dupqV4xKtvGlV0jVDRULyjEp03n/1YTRVKeCN8xhxzfYpT80Mo9cJXRI2W mDGhS/6PmrF/gXrDDee3jmahX/vNdda2y4mSviLHp4Eu/8XyBfdPfhTb/ctHe/De74ftR82UdPM LRTeXGtv0WXIqOdz5pkz8nhCr1 X-Received: by 2002:a05:6102:41a7:b0:73e:c6a0:328 with SMTP id ada2fe7eead31-744b7dacf37mr2764669137.19.1783431182746; Tue, 07 Jul 2026 06:33:02 -0700 (PDT) X-Received: by 2002:a05:6102:41a7:b0:73e:c6a0:328 with SMTP id ada2fe7eead31-744b7dacf37mr2764645137.19.1783431182172; Tue, 07 Jul 2026 06:33:02 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aed13c8b5bsm3805297e87.80.2026.07.07.06.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2026 06:33:00 -0700 (PDT) Date: Tue, 7 Jul 2026 16:32:59 +0300 From: Dmitry Baryshkov To: "Gjorgji Rosikopulos (Consultant)" Cc: Vladimir Zapolskiy , Atanas Filipov , linux-media@vger.kernel.org, bryan.odonoghue@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 5/5] media: qcom: jpeg: Add Qualcomm JPEG V4L2 encoder Message-ID: References: <20260706071113.383215-1-atanas.filipov@oss.qualcomm.com> <20260706071113.383215-6-atanas.filipov@oss.qualcomm.com> <51a0abf2-2a72-4551-894b-2c2de91ba0c2@linaro.org> <74a5b549-987c-4dac-a1a0-ff81150cd6ab@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <74a5b549-987c-4dac-a1a0-ff81150cd6ab@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDEzMiBTYWx0ZWRfX/yC4J9D6qhnj Ku9PTnGUbjwA0ImjfEOWitaT6oiZsY2qbkS+Dkzvggn1gtMIfOcOte96egU9kLw7SCFh5URZ+w3 IBEt17iuNzwR1XFCpb/nAyTLW1VpYHjtESNq2w585SPju66H1d82NR8OKlH6HTOs9TGkRPk/IMc zle3lIuPIw4Ox2s0pPd+mqpXBAmV0YMr9YuHSWvLCzEl8+1+Rk165/Q2mv7H+cpdXywyFru+7o8 suBzYCMiZ0UFoc4YMKBMDO2hDkS2W+MtQ+Cf8M1D7RI3wtK/SoXbpIo856jYBpXpNxpZorCgC2r DCDiYYvpP8axq72L+ATm4P+1zRv63VAc2U8dZ5FRTBMF30s4Pm/2TWrfGEv+fr1AgYT8vjeScoa +15sQoVk+cz+S4B28PnzCSrN1s/FhYOm9AkePVl6Rw/l5KDV0EPQLPv0JEeh4MOTEZmstTq71yG x51J6slLK82PG4TYiNg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDEzMiBTYWx0ZWRfX5mYac8nm9/7H OCyGuBThNBCUrP4bp/rP+IXZmzbMHOdf6dEd+dxqwkNu6B35iSMLNsXHKOHuykIv3G5xdnWOC3T +1WyOxADQW4MZWgM25iERNu2rMakI64= X-Proofpoint-GUID: W66_yynSuQ4QkwYxCNBPQVeaRnn6P6D3 X-Authority-Analysis: v=2.4 cv=UvdT8ewB c=1 sm=1 tr=0 ts=6a4d000f cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=ahtVEZUH5jVL-0juYUwA:9 a=3ZKOabzyN94A:10 a=wPNLvfGTeEIA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-ORIG-GUID: W66_yynSuQ4QkwYxCNBPQVeaRnn6P6D3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_03,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070132 On Tue, Jul 07, 2026 at 04:24:19PM +0300, Gjorgji Rosikopulos (Consultant) wrote: > Hi Vlad, > > On 7/6/2026 10:46 AM, Vladimir Zapolskiy wrote: > > > > > > > +            interconnects = <&gem_noc MASTER_AMPSS_M0 > > > QCOM_ICC_TAG_ACTIVE_ONLY > > > +                             &config_noc SLAVE_CAMERA_CFG > > > QCOM_ICC_TAG_ACTIVE_ONLY>, > > > +                            <&mmss_noc MASTER_CAMNOC_HF > > > QCOM_ICC_TAG_ALWAYS > > > +                             &mc_virt SLAVE_EBI_CH0 > > > QCOM_ICC_TAG_ALWAYS>, > > > +                            <&mmss_noc MASTER_CAMNOC_SF > > > QCOM_ICC_TAG_ALWAYS > > > +                             &mc_virt SLAVE_EBI_CH0 > > > QCOM_ICC_TAG_ALWAYS>; > > > +            interconnect-names = "cpu-cfg", > > > +                                 "hf-mnoc", > > > +                                 "sf-mnoc"; > > > > This is the topic, which may raise a disagreement, but I'll repeat my > > position about the need to remove all "CAMSS bus" specific resources from > > the device node, they are found and should be allocated on parent's side. > > The interconnect has functionality to handle bw requests from different > clients. > > Yes the best will be to have camss interconnect, so jpeg and other hw's to > vote > > on that (actually it is possible in icc framework) but what is the benefit > of moving > > those to camss? Is it not better to create camss icc. I understand Please fix your email client and stop inserting extra empty lines. > > you want them to be on parent side. But how to vote on bw? Most of the time > it If the driver actually votes on those, I think, it should be fine. This patchset seemed to add bandwidth voting, but then it dropped all the votes in the last commit. > > depends on the jpeg encoder configuration based on resolution format etc. to > set properly average bw. > > So i dont see how that can be done with not explicit dependency on jpeg with > camss and some exported > > API's which we discussed with Bryan they are preferable. Interconnects should be fine to be referenced here. Especially, if JPEG has its own port to those busses (hint, commit message). As I wrote, I see a bigger issue with the clocks. You need to have some API to vote on them (and then let camss driver aggregate those votes in a platform-specific manner). > > Maybe i do not understand properly the proposal but can you just add some > pseudo code > > how you see the things? > > Regards, > > ~Gjorgji > -- With best wishes Dmitry