mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] rd: Remove ramdisk_set_page_dirty
Date: Thu, 31 May 2007 10:40:03 -0600	[thread overview]
Message-ID: <m11wgx3q1o.fsf_-_@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070531085556.11649c70.akpm@linux-foundation.org> (Andrew Morton's message of "Thu, 31 May 2007 08:55:56 -0700")


The generic function __set_page_dirty_buffers called by default by
set_page_dirty appears to be a correct superset of ramdisk_set_page_dirty.
So remove the specialized ramdisk version.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 drivers/block/rd.c |   27 ---------------------------
 1 files changed, 0 insertions(+), 27 deletions(-)

diff --git a/drivers/block/rd.c b/drivers/block/rd.c
index 56b2b54..26b4c6f 100644
--- a/drivers/block/rd.c
+++ b/drivers/block/rd.c
@@ -114,37 +114,10 @@ static int ramdisk_readpage(struct file *file, struct page *page)
 	return 0;
 }
 
-/*
- * ramdisk blockdev pages have their own ->set_page_dirty() because we don't
- * want them to contribute to dirty memory accounting.
- */
-static int ramdisk_set_page_dirty(struct page *page)
-{
-	struct address_space * const mapping = page_mapping(page);
-
-	spin_lock(&mapping->private_lock);
-	if (page_has_buffers(page)) {
-		struct buffer_head *head = page_buffers(page);
-		struct buffer_head *bh = head;
-
-		do {
-			set_buffer_uptodate(bh);
-			set_buffer_dirty(bh);
-			bh = bh->b_this_page;
-		} while (bh != head);
-	}
-	spin_unlock(&mapping->private_lock);
-
-	if (!TestSetPageDirty(page))
-		return 1;
-	return 0;
-}
-
 static const struct address_space_operations ramdisk_aops = {
 	.readpage	= ramdisk_readpage,
 	.prepare_write	= simple_prepare_write,
 	.commit_write	= simple_commit_write,
-	.set_page_dirty	= ramdisk_set_page_dirty,
 };
 
 static int rd_blkdev_pagecache_IO(int rw, struct bio_vec *vec, sector_t sector,
-- 
1.5.1.1.181.g2de0


  reply	other threads:[~2007-05-31 16:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-22  2:31 [PATCH 1/3] Preserve the dirty bit in init_page_buffers Eric W. Biederman
2007-05-22  2:36 ` [PATCH 2/3] rd: Mark ramdisk buffer heads dirty in ramdisk_set_page_dirty Eric W. Biederman
2007-05-22  2:40   ` [PATCH 3/3] rd: Simplify by using the same helper functions in libfs Eric W. Biederman
2007-05-28  4:09 ` [PATCH 1/3] Preserve the dirty bit in init_page_buffers Nick Piggin
2007-05-28  4:30   ` Eric W. Biederman
2007-05-28  4:54     ` Nick Piggin
2007-05-28  4:59       ` Nick Piggin
2007-05-28 14:05         ` Eric W. Biederman
2007-05-29  5:14           ` Nick Piggin
2007-05-29  5:28             ` Eric W. Biederman
2007-05-31 11:56             ` Eric W. Biederman
2007-05-31 15:55               ` Andrew Morton
2007-05-31 16:40                 ` Eric W. Biederman [this message]
2007-05-31 16:43                 ` [PATCH] buffer: Kill old incorrect? comment Eric W. Biederman
2007-05-28 13:52       ` [PATCH 1/3] Preserve the dirty bit in init_page_buffers Eric W. Biederman
2007-05-28  6:37     ` Nick Piggin
2007-05-28 13:58       ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m11wgx3q1o.fsf_-_@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®