From: ebiederm@xmission.com (Eric W. Biederman)
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] de_thread: Don't confuse users do_each_thread.
Date: Tue, 11 Apr 2006 01:36:13 -0600 [thread overview]
Message-ID: <m11ww4d0nm.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <200604110925.08685.ioe-lkml@rameria.de> (Ingo Oeser's message of "Tue, 11 Apr 2006 09:25:07 +0200")
Ingo Oeser <ioe-lkml@rameria.de> writes:
> On Tuesday, 11. April 2006 12:19, Oleg Nesterov wrote:
>> On 04/11, Ingo Oeser wrote:
>> >
>> > While you are at it: Could you please avoid calculating current over
>> > and over again?
>> >
>> > Just calculate it once and use the task_struct pointer.
>>
>> Ironically, de_thread() has 'tsk' parameter which is equal to 'current'.
>
> That's the thing that made me doubt :-)
>
> But thinking more about it: current cannot change within one thread,
> right? So all of this can be cleaned up.
>
> I'll clean them up tonight and sent out a patch against current -mm.
Please skip de_thread. I will catch that one, in a minute. There is
enough churn on that function that you are likely to patch the wrong
version.
Eric
next prev parent reply other threads:[~2006-04-11 7:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-06 22:04 [PATCH rc1-mm] de_thread: fix deadlockable process addition Oleg Nesterov
2006-04-06 22:58 ` Eric W. Biederman
2006-04-07 23:46 ` Oleg Nesterov
2006-04-07 22:51 ` Andrew Morton
2006-04-07 22:56 ` Andrew Morton
2006-04-08 7:55 ` Eric W. Biederman
2006-04-08 17:27 ` Oleg Nesterov
2006-04-08 16:07 ` Eric W. Biederman
2006-04-08 21:13 ` Oleg Nesterov
2006-04-08 21:23 ` Oleg Nesterov
2006-04-10 22:11 ` Eric W. Biederman
2006-04-10 23:07 ` [PATCH] de_thread: Don't confuse users do_each_thread Eric W. Biederman
2006-04-10 23:16 ` Eric W. Biederman
2006-04-10 23:52 ` Ingo Oeser
2006-04-11 6:18 ` Eric W. Biederman
2006-04-11 10:19 ` Oleg Nesterov
2006-04-11 7:25 ` Ingo Oeser
2006-04-11 7:36 ` Eric W. Biederman [this message]
2006-04-11 19:50 ` Ingo Oeser
2006-04-11 10:05 ` Oleg Nesterov
2006-04-11 5:23 ` Andrew Morton
2006-04-11 10:47 ` Oleg Nesterov
2006-04-11 6:23 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11ww4d0nm.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome