mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@osdl.org>
Cc: Yinghai Lu <yinghai.lu@amd.com>,
	vgoyal@in.ibm.com, ak@muc.de, fastboot@lists.osdl.org,
	linux-kernel@vger.kernel.org, discuss@x86-64.org,
	linuxbios@openbios.org
Subject: [PATCH] i386 io_apic: Use correct index variable when computing the apic that is in ExtInt mode.
Date: Fri, 06 Jan 2006 01:14:16 -0700	[thread overview]
Message-ID: <m11wzl6aef.fsf_-_@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060105163848.3275a220.akpm@osdl.org> (Andrew Morton's message of "Thu, 5 Jan 2006 16:38:48 -0800")


Somehow in all of the chaos this one line bug fix got merged with
the another patch and was then discarded when issues were found
with that other patch.

 From: Vivek Goyal <vgoyal@in.ibm.com>

  A minor fix to the patch which remembers the location of where i8259 is
  connected.  Now counter i has been replaced by apic.  counter i is having
  some junk value which was leading to non-detection of i8259 connected to
  IOAPIC.

---

 arch/i386/kernel/io_apic.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

b5a215b462de26a1e6c21f607677796f0bb446aa
diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c
index 7554f8f..f2dd218 100644
--- a/arch/i386/kernel/io_apic.c
+++ b/arch/i386/kernel/io_apic.c
@@ -1649,7 +1649,7 @@ static void __init enable_IO_APIC(void)
 	for(apic = 0; apic < nr_ioapics; apic++) {
 		int pin;
 		/* See if any of the pins is in ExtINT mode */
-		for(pin = 0; pin < nr_ioapic_registers[i]; pin++) {
+		for (pin = 0; pin < nr_ioapic_registers[apic]; pin++) {
 			struct IO_APIC_route_entry entry;
 			spin_lock_irqsave(&ioapic_lock, flags);
 			*(((int *)&entry) + 0) = io_apic_read(apic, 0x10 + 2 * pin);

  parent reply	other threads:[~2006-01-06  8:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-03  4:46 Inclusion of x86_64 memorize ioapic at bootup patch Vivek Goyal
2006-01-06  0:30 ` Yinghai Lu
2006-01-06  0:38   ` Andrew Morton
2006-01-06  4:50     ` Vivek Goyal
2006-01-06  8:02     ` Eric W. Biederman
2006-01-06 15:26       ` [LinuxBIOS] " Ronald G Minnich
2006-01-06 18:59       ` Andi Kleen
2006-01-06  8:14     ` Eric W. Biederman [this message]
2006-01-06  8:20     ` [PATCH] x86_64 io_apic: memorize at bootup where the i8259 is Eric W. Biederman
2006-01-07  0:44       ` Yinghai Lu
2006-01-07  1:29         ` [PATCH] x86_64 io_apic: memorize at bootup where the i8259 is (typo fix) Eric W. Biederman
2006-01-06  8:24   ` Inclusion of x86_64 memorize ioapic at bootup patch Eric W. Biederman
2006-01-06 23:48 ` Andi Kleen
2006-01-07  0:00   ` Yinghai Lu
2006-01-07  0:29     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m11wzl6aef.fsf_-_@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=discuss@x86-64.org \
    --cc=fastboot@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxbios@openbios.org \
    --cc=vgoyal@in.ibm.com \
    --cc=yinghai.lu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®