From: ebiederm@xmission.com (Eric W. Biederman)
To: michael@ellerman.id.au
Cc: linux-pci@atrey.karlin.mff.cuni.cz,
Greg Kroah-Hartman <greg@kroah.com>,
"David S. Miller" <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
daniel.e.wolstenholme@intel.com
Subject: Re: [PATCH 14/21] MSI: Use a list instead of the custom link structure
Date: Wed, 28 Mar 2007 23:24:00 -0600 [thread overview]
Message-ID: <m13b3omxlb.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <1175144609.16660.33.camel@concordia.ozlabs.ibm.com> (Michael Ellerman's message of "Thu, 29 Mar 2007 15:03:29 +1000")
Michael Ellerman <michael@ellerman.id.au> writes:
>
> I thought about doing it in the MSI enable methods, but I think it
> really belongs in the (nonexistant) routine that allocs and sets up a
> pci_dev.
I agree that would be a good place for it as well.
> I think it's pretty dicy to be passing around a pci_dev with an
> uninitialised msi_list. Even if currently no code outside the MSI enable
> methods looks at it, I think we're asking for bugs in the future.
Reasonable.
> So I'll do a patch which adds alloc_pci_dev(), update the callers, and
> then put the msi_list initialisation in there.
Sounds good. That will allow us to initialize all of the fields in struct
pci_dev to a default value in one place.
Eric
prev parent reply other threads:[~2007-03-29 5:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070322105343.3B358DDF6D@ozlabs.org>
2007-03-28 6:29 ` Eric W. Biederman
2007-03-29 5:03 ` Michael Ellerman
2007-03-29 5:24 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m13b3omxlb.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=daniel.e.wolstenholme@intel.com \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome