From: ebiederm@xmission.com (Eric W. Biederman)
To: Con Kolivas <kernel@kolivas.org>
Cc: linux-kernel@vger.kernel.org, Horms <horms@verge.net.au>,
"Randy.Dunlap" <rdunlap@xenotime.net>,
fastboot@osdl.org
Subject: Re: [PATCH] kexec: typo in machine_kexec()
Date: Wed, 05 Apr 2006 09:49:40 -0600 [thread overview]
Message-ID: <m13bgs3tuz.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <200604051624.35358.kernel@kolivas.org> (Con Kolivas's message of "Wed, 5 Apr 2006 16:24:34 +1000")
How does this look for making that comment readable?
Eric
diff --git a/arch/i386/kernel/machine_kexec.c b/arch/i386/kernel/machine_kexec.c
index f73d737..7a344b6 100644
--- a/arch/i386/kernel/machine_kexec.c
+++ b/arch/i386/kernel/machine_kexec.c
@@ -189,14 +189,11 @@ NORET_TYPE void machine_kexec(struct kim
memcpy((void *)reboot_code_buffer, relocate_new_kernel,
relocate_new_kernel_size);
- /* The segment registers are funny things, they are
- * automatically loaded from a table, in memory wherever you
- * set them to a specific selector, but this table is never
- * accessed again you set the segment to a different selector.
- *
- * The more common model is are caches where the behide
- * the scenes work is done, but is also dropped at arbitrary
- * times.
+ /* The segment registers are funny things, they have both a
+ * visible and an invisible part. Whenver the visible part is
+ * set to a specific selector, the invisible part is loaded
+ * with from a table in memory. At no other time is the
+ * descriptor table in memory accessed.
*
* I take advantage of this here by force loading the
* segments, before I zap the gdt with an invalid value.
next prev parent reply other threads:[~2006-04-05 16:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-04 23:48 Horms
2006-04-05 3:05 ` Randy.Dunlap
2006-04-05 5:56 ` Eric W. Biederman
2006-04-05 15:19 ` [PATCH] kexec: update MAINTAINERS Randy.Dunlap
2006-04-05 5:57 ` [PATCH] kexec: typo in machine_kexec() Horms
2006-04-05 6:24 ` Con Kolivas
2006-04-05 15:49 ` Eric W. Biederman [this message]
2006-04-05 17:09 ` Randy.Dunlap
2006-05-20 2:09 ` Horms
2006-04-05 3:10 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m13bgs3tuz.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=fastboot@osdl.org \
--cc=horms@verge.net.au \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome