From: Rusty Russell <rusty@rustcorp.com.au>
To: torvalds@transmeta.com, Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] max_fds race in select().
Date: Fri, 04 May 2001 14:10:21 +1000 [thread overview]
Message-ID: <m14vWv7-001QLxC@mozart> (raw)
We can end up with the user getting more fds tban they asked for...
Unlikely, but possible,
Rusty.
--- linux-2.4.4-official/fs/select.c Thu Feb 22 14:25:36 2001
+++ working-2.4.4-rcu/fs/select.c Fri May 4 14:06:39 2001
@@ -260,7 +260,7 @@
fd_set_bits fds;
char *bits;
long timeout;
- int ret, size;
+ int ret, size, max_fdset;
timeout = MAX_SCHEDULE_TIMEOUT;
if (tvp) {
@@ -285,8 +285,10 @@
if (n < 0)
goto out_nofds;
- if (n > current->files->max_fdset)
- n = current->files->max_fdset;
+ /* max_fdset can increase, so grab it once to avoid race */
+ max_fdset = current->files->max_fdset;
+ if (n > max_fdset)
+ n = max_fdset;
/*
* We need 6 bitmaps (in/out/ex for both incoming and outgoing),
--
Premature optmztion is rt of all evl. --DK
next reply other threads:[~2001-05-04 4:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-04 4:10 Rusty Russell [this message]
2001-05-04 4:10 ` Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m14vWv7-001QLxC@mozart \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®