mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: arjanv@redhat.com
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Jamie Lokier <jamie@shareable.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Can we kill f inb_p, outb_p and other random I/O on port 0x80, in 2.6?
Date: 22 Sep 2003 12:58:04 -0600	[thread overview]
Message-ID: <m165jkk5vn.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <1064250691.6235.2.camel@laptop.fenrus.com>

Arjan van de Ven <arjanv@redhat.com> writes:

> On Mon, 2003-09-22 at 18:33, Alan Cox wrote:
> \
> > > I've also seen much DOS code that didn't have extra delays for
> > > keyboard I/Os.  What sort of breakage did you observe with the
> > > keyboard?
> > 
> > DEC laptops hang is the well known example of that one.
> > 
> > I'm *for* making this change to udelay, it just has to start up with a
> > suitably pessimal udelay assumption until calibrated.
> 
> or we make udelay() do the port 80 access in the uncalibrated case....
> 
> The first person to complain about the extra branch miss in udelay for
> this will get laughed at by me ;)

Sounds like a solution.  I will see what I can do in that direction.
Maintaining a suitably pessimistic udelay with multi gigahertz chips
sounds like a challenge, so using outb to port 0x80 may be a
reasonable solution there. 

Alan, can you describe a little more what the original delay is needed
for?  I don't see it documented in my 8254 data sheet.  The better I
can understand the problem the better I can write the comments on this
magic bit of code as I fix it.

The oldest machine I have is a 386 MCA system.  Any chance of the bug
showing up there?  I'd love to have a test case.

Another reason for fixing this is we are killing who knows how much
I/O bandwidth with this stream of failing writes to port 0x80.

Eric

  parent reply	other threads:[~2003-09-22 18:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-22  0:27 Eric W. Biederman
2003-09-22 11:22 ` Alan Cox
2003-09-22 16:26   ` Jamie Lokier
2003-09-22 16:33     ` Alan Cox
2003-09-22 17:11       ` Arjan van de Ven
2003-09-22 18:28         ` Jamie Lokier
2003-09-22 19:09           ` Eric W. Biederman
2003-09-22 19:27           ` Arjan van de Ven
2003-09-22 21:46             ` Jamie Lokier
2003-09-23 18:17           ` bill davidsen
2003-09-22 18:58         ` Eric W. Biederman [this message]
2003-09-22 19:19           ` Jamie Lokier
2003-09-23  0:09           ` Alan Cox
2003-09-23 18:20             ` bill davidsen
2003-09-22 19:00       ` Jamie Lokier
2003-09-22 20:05         ` Eric W. Biederman
2003-09-23 18:31           ` bill davidsen
2003-09-23  0:13         ` Alan Cox
     [not found] <20030922153651.16497.qmail@science.horizon.com>
2003-09-22 18:35 ` Eric W. Biederman
2003-09-22 21:54   ` Jamie Lokier
2003-09-23 18:41     ` bill davidsen
2003-09-24 17:43       ` Linus Torvalds
2003-09-22 20:03 John Bradford
2003-09-22 21:37 ` Jamie Lokier
2003-09-22 21:42   ` Arjan van de Ven
2003-09-23  0:16   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m165jkk5vn.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjanv@redhat.com \
    --cc=jamie@shareable.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®