From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757447AbYIIUPT (ORCPT ); Tue, 9 Sep 2008 16:15:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755177AbYIIUPF (ORCPT ); Tue, 9 Sep 2008 16:15:05 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:42918 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754591AbYIIUPD (ORCPT ); Tue, 9 Sep 2008 16:15:03 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Chuck Lever Cc: "Serge E. Hallyn" , Cedric Le Goater , Andrew Morton , Trond Myklebust , Linux Kernel Mailing List , Linux Containers , linux-nfs@vger.kernel.org References: <48C52B29.4020204@fr.ibm.com> <20080909124311.GA10053@us.ibm.com> <20080909152952.GA21207@us.ibm.com> <869FF00C-4DAF-4D19-80AF-9230617A9223@oracle.com> Date: Tue, 09 Sep 2008 13:08:29 -0700 In-Reply-To: <869FF00C-4DAF-4D19-80AF-9230617A9223@oracle.com> (Chuck Lever's message of "Tue, 9 Sep 2008 15:00:55 -0400") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=mx04.mta.xmission.com;;;ip=24.130.11.59;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 24.130.11.59 X-SA-Exim-Rcpt-To: too long (recipient list exceeded maximum allowed size of 128 bytes) X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-DCC: XMission; sa02 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;Chuck Lever X-Spam-Relay-Country: X-Spam-Report: * -1.8 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -0.2 BAYES_40 BODY: Bayesian spam probability is 20 to 40% * [score: 0.3399] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa02 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 XM_SPF_Neutral SPF-Neutral Subject: Re: [RFC][PATCH] sunrpc: fix oops in rpc_create() when the mount namespace is unshared X-SA-Exim-Version: 4.2.1 (built Thu, 07 Dec 2006 04:40:56 +0000) X-SA-Exim-Scanned: Yes (on mx04.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chuck Lever writes: > On Sep 9, 2008, at Sep 9, 2008, 2:20 PM, ebiederm@xmission.com wrote: >> Chuck Lever writes: >> >>> If the upper layers are responsible for providing the utsname, you will need >>> to >>> fix up lockd and the NFS server's callback client too, at least. >> >> Actually looking at the code. It looks like a proper fix may be even simpler. >> Why do we have both clnt->cl_server and clnt->cl_nodename? Or is cl_server >> the other side of the connection? > > cl_server is the server-side. cl_nodename is the "machine name" of the client. Thanks, Darn. Looks like we need to capture both names at the same or a similar point. I'm wondering if we need to capture a network namespace as well. >>> I don't like the idea of an oops in here. Instead, (for now) it should warn >>> and >>> fail to create the client, IMO. >> >> Which is interesting when the problem happens during NFS unmount. Although >> frankly it could fail anyway. >> >> It seems strange that we are creating a client during unmount anyway. > > It's worth investigating. Just enable RPC tracing (/usr/sbin/rpcdebug -m rpc -s > all) before shutting down the client. > > NFS unmounting is historically difficult because during a system shutdown, > unmounting is the last thing to occur, and usually happens after most system > services (such as the portmapper service) have become unavailable. That's fine > for local file systems, but it makes for a rather dodgy situation for NFS. Interesting. Eric