From: ebiederm@xmission.com (Eric W. Biederman)
To: linux-kernel@vger.kernel.org
Cc: Eric Brower <ebrower@usa.net>
Subject: Re: [PATCH] ethtool.h should use userspace-accessible types
Date: 12 Mar 2004 09:25:16 -0700 [thread overview]
Message-ID: <m17jxqf2xf.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <40511868.4060109@usa.net>
Eric Brower <ebrower@usa.net> writes:
> Attached is a patch to 2.4's ethtool.h to use appropriate, userspace-accessible
> data types (__u8 and friends, rather than u8 and friends).
Why there is no #ifdef __KERNEL__ in this header to make it userspace
safe.
> I've also posted a patch against ethtool-1.8 to the sf.net gkernel site that
> cleans-up ethtool-copy.h and the rest in the same manner.
In user space the types from stdint.h likely should be used. So __u8
and friends looks wrong there as well.
Eric
next prev parent reply other threads:[~2004-03-12 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-12 1:54 Eric Brower
2004-03-12 2:35 ` Tim Hockin
2004-03-12 4:57 ` Greg KH
2004-03-12 9:19 ` Tim Hockin
2004-03-12 16:25 ` Eric W. Biederman [this message]
2004-03-12 16:54 ` Jeff Garzik
2004-03-12 17:06 ` Eric W. Biederman
2004-03-12 21:48 ` Jonathan Lundell
2004-03-14 3:25 ` Matt Mackall
2004-03-15 21:24 ` Jonathan Lundell
2004-03-12 16:54 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17jxqf2xf.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ebrower@usa.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®