mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@osdl.org>
Cc: Fernando Luis Vazquez Cao <fernando@intellilink.co.jp>,
	ak@suse.de, vgoyal@in.ibm.com, linux-kernel@vger.kernel.org,
	fastboot@lists.osdl.org
Subject: Re: [PATCH 1/5] stack overflow safe kdump (2.6.16-rc1-i386) - safe_smp_processor_id
Date: Wed, 25 Jan 2006 03:23:40 -0700	[thread overview]
Message-ID: <m1acdkk3mb.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060124231052.7c9fcbec.akpm@osdl.org> (Andrew Morton's message of "Tue, 24 Jan 2006 23:10:52 -0800")

Andrew Morton <akpm@osdl.org> writes:

> It assumes that all x86 SMP machines have APICs.  That's untrue of Voyager.
> I think we can probably live with this assumption - others would know
> better than I.

So looking at the code hard_smp_processor_id is fine.  Voyager
also implements that.

If we are running UP with an SMP kernel we are fine.

But I think x86_cpu_to_apicid will get us into trouble
on Voyager, because I don't think we should compile smpboot.c
as it has conflicting simples with voyager_smp.c

Although reading the makefile I don't see how we can avoid
compiling them both in SMP mode.

Everything else has a local apic when running SMP so we should
be good there.

Eric




      parent reply	other threads:[~2006-01-25 10:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-25  6:51 Fernando Luis Vazquez Cao
2006-01-25  7:10 ` Andrew Morton
2006-01-25  7:53   ` Andi Kleen
2006-01-25  7:59     ` Andrew Morton
2006-01-25  8:07       ` Arjan van de Ven
2006-01-25  8:50         ` Fernando Luis Vazquez Cao
2006-01-25 10:27           ` Eric W. Biederman
2006-01-25  9:41       ` Andi Kleen
2006-01-25 10:23   ` Eric W. Biederman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1acdkk3mb.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=fastboot@lists.osdl.org \
    --cc=fernando@intellilink.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®