From: ebiederm@xmission.com (Eric W. Biederman)
To: Adrian Bunk <bunk@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fs/proc/proc_net.c: make a struct static
Date: Wed, 24 Oct 2007 12:18:22 -0600 [thread overview]
Message-ID: <m1bqao8jgx.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20071024162329.GQ30533@stusta.de> (Adrian Bunk's message of "Wed, 24 Oct 2007 18:23:29 +0200")
Adrian Bunk <bunk@kernel.org> writes:
> Struct proc_net_ns_ops can become static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Don't have a clue why I didn't make it static originally.
> ---
> 5ae49d45bc25eed356ecbe3592db270bfa1d9b73
> diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c
> index 2e91fb7..4edaad0 100644
> --- a/fs/proc/proc_net.c
> +++ b/fs/proc/proc_net.c
> @@ -185,7 +185,7 @@ static __net_exit void proc_net_ns_exit(struct net *net)
> kfree(net->proc_net_root);
> }
>
> -struct pernet_operations __net_initdata proc_net_ns_ops = {
> +static struct pernet_operations __net_initdata proc_net_ns_ops = {
> .init = proc_net_ns_init,
> .exit = proc_net_ns_exit,
> };
next prev parent reply other threads:[~2007-10-24 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:23 Adrian Bunk
2007-10-24 18:18 ` Eric W. Biederman [this message]
2007-10-26 10:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1bqao8jgx.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®