From: ebiederm@xmission.com (Eric W. Biederman)
To: Simon Arlott <58022e3be4e86309571hlooq00057abw@thunder.lp0.eu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [irq: Remove set_native_irq_info] !CONFIG_SMP regression
Date: Mon, 26 Feb 2007 16:50:33 -0700 [thread overview]
Message-ID: <m1bqjgo4vq.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <45E3663B.4000701@simon.arlott.org.uk> (Simon Arlott's message of "Mon, 26 Feb 2007 22:59:07 +0000")
Simon Arlott <simon@arlott.org> writes:
> 9f0a5ba5508143731dc63235de19659be20d26dc is first bad commit
> commit 9f0a5ba5508143731dc63235de19659be20d26dc
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date: Fri Feb 23 04:13:55 2007 -0700
>
> [PATCH] irq: Remove set_native_irq_info
>
> This patch replaces all instances of "set_native_irq_info(irq, mask)"
> with "irq_desc[irq].affinity = mask". The latter form is clearer
> uses fewer abstractions, and makes access to this field uniform
> accross different architectures.
>
>
>
> arch/i386/kernel/io_apic.c: In function `setup_IO_APIC_irqs':
> arch/i386/kernel/io_apic.c:1357: error: structure has no member named `affinity'
> arch/i386/kernel/io_apic.c: In function `io_apic_set_pci_routing':
> arch/i386/kernel/io_apic.c:2878: error: structure has no member named `affinity'
>
>
> The original version was an empty function if !CONFIG_SMP, struct irq_desc only
> has 'affinity' on SMP.
Yep.
Give me a bit. I think we can just kill those lines.
Eric
next prev parent reply other threads:[~2007-02-26 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 22:59 Simon Arlott
2007-02-26 23:50 ` Eric W. Biederman [this message]
2007-02-27 7:27 ` [PATCH] x86_64/i386 irq: Fix !CONFIG_SMP compilation Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1bqjgo4vq.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=58022e3be4e86309571hlooq00057abw@thunder.lp0.eu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®