From: ebiederm@xmission.com (Eric W. Biederman)
To: Kirill Korotaev <dev@openvz.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Linux Containers <containers@lists.osdl.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@tv-sign.ru>,
Pavel Emelyanov <xemul@openvz.org>
Subject: Re: [PATCH] pidns: Limit kill -1 and cap_set_all
Date: Mon, 29 Oct 2007 12:07:29 -0600 [thread overview]
Message-ID: <m1d4uxpzfi.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <47259BE9.4050904@openvz.org> (Kirill Korotaev's message of "Mon, 29 Oct 2007 11:38:01 +0300")
Kirill Korotaev <dev@openvz.org> writes:
> I dislike this patch:
> it's not scalable/efficient to travers all the tasks
> while we know the pid namespace we care about.
Well the unix way is to implement it simple and stupid and then to
optimize, where needed. We don't currently have a per pid namespace
list of processes or tasks.
This is a trivial bug fix patch, and I wanted the review to be as
simple as possible.
I don't expect people are doing kill -1 all that frequently as it is a
bit rude.
I have no problem doing find_ge_pid and then looking in the hash table
like we do in /proc. It likely will have fewer conflicts, but that
is a bit harder to review, and is actually more code.
Eric
next prev parent reply other threads:[~2007-10-29 18:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 17:48 [PATCH] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks Eric W. Biederman
2007-10-26 18:06 ` Linus Torvalds
2007-10-26 18:36 ` Eric W. Biederman
2007-10-26 19:43 ` [PATCH] proc: Simplify and correct proc_flush_task Eric W. Biederman
2007-10-26 20:37 ` [PATCH] pidns: Limit kill -1 and cap_set_all Eric W. Biederman
2007-10-29 8:38 ` Kirill Korotaev
2007-10-29 18:07 ` Eric W. Biederman [this message]
2007-10-29 16:02 ` Dave Hansen
2007-10-29 17:59 ` Eric W. Biederman
2007-10-29 18:07 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1d4uxpzfi.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=dev@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=torvalds@linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®