From: ebiederm@xmission.com (Eric W. Biederman)
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-pci@atrey.karlin.mff.cuni.cz,
Greg Kroah-Hartman <greg@kroah.com>,
"David S. Miller" <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
<linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>,
<daniel.e.wolstenholme@intel.com>
Subject: Re: [PATCH 5/21] MSI: Consolidate MSI-X irq freeing code
Date: Tue, 27 Mar 2007 22:26:27 -0600 [thread overview]
Message-ID: <m1d52ut2mk.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070322105335.33AD5DDF5D@ozlabs.org> (Michael Ellerman's message of "Thu, 22 Mar 2007 21:51:33 +1100")
Michael Ellerman <michael@ellerman.id.au> writes:
> For the MSI-X case we do exactly the same logic in pci_disable_msix() and
> msi_remove_pci_irq_vectors(), so consolidate them.
>
> msi_remove_pci_irq_vectors() wasn't setting dev->first_msi_irq to 0, but
> I think it should have been, so the consolidated version does.
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
parent reply other threads:[~2007-03-28 4:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20070322105335.33AD5DDF5D@ozlabs.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1d52ut2mk.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=daniel.e.wolstenholme@intel.com \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome