From: ebiederm@xmission.com (Eric W. Biederman)
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: linux-kernel@vger.kernel.org, Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] choose_new_parent: remove unused arg, sanitize exit_state check
Date: Wed, 01 Feb 2006 22:36:48 -0700 [thread overview]
Message-ID: <m1d5i6wccv.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <43E1106B.E1D73FE6@tv-sign.ru> (Oleg Nesterov's message of "Wed, 01 Feb 2006 22:47:55 +0300")
Oleg Nesterov <oleg@tv-sign.ru> writes:
> 'child_reaper' arg is not used in choose_new_parent().
>
> "->exit_state >= EXIT_ZOMBIE" check is a leftover, was
> valid when EXIT_ZOMBIE lived in ->state var.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Looks good. I have been tripping over that extra parameter
in choose_new_parent for a while now.
Acked-by: Eric Biederman <ebiederm@xmission.com>
prev parent reply other threads:[~2006-02-02 5:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-01 19:47 Oleg Nesterov
2006-02-02 5:36 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1d5i6wccv.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®