From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031031AbXDXCKp (ORCPT ); Mon, 23 Apr 2007 22:10:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1031029AbXDXCKp (ORCPT ); Mon, 23 Apr 2007 22:10:45 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:50982 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031023AbXDXCKo (ORCPT ); Mon, 23 Apr 2007 22:10:44 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Benjamin Herrenschmidt Cc: Linas Vepstas , Christoph Hellwig , ", containers@lists.osdl.org, Oleg Nesterov , linux-kernel@vger.kernel.org, Paul Mackerras , linux-s390@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH] powerpc pseries eeh: Convert to kthread API References: <11769695763104-git-send-email-ebiederm@xmission.com> <20070422123155.GF20763@infradead.org> <20070423205020.GR31947@austin.ibm.com> <1177378733.14873.52.camel@localhost.localdomain> Date: Mon, 23 Apr 2007 20:08:42 -0600 In-Reply-To: <1177378733.14873.52.camel@localhost.localdomain> (Benjamin Herrenschmidt's message of "Tue, 24 Apr 2007 11:38:53 +1000") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Benjamin Herrenschmidt writes: >> The only reason for using threads here is to get the error recovery >> out of an interrupt context (where errors may be detected), and then, >> an hour later, decrement a counter (which is how we limit these to >> 6 per hour). Thread reaping is "trivial", the thread just exits >> after an hour. > > In addition, it should be a thread and not done from within keventd > because : > > - It can take a long time (well, relatively but still too long for a > work queue) > > - The driver callbacks might need to use keventd or do flush_workqueue > to synchronize with their own workqueues when doing an internal > recovery. > >> Since these are events rare, I've no particular concern about >> performance or resource consumption. The current code seems >> to work just fine. :-) > > I think moving to kthread's is cleaner (just a wrapper around kernel > threads that simplify dealing with reaping them out mostly) and I agree > with Christoph that it would be nice to be able to "fire off" kthreads > from interrupt context.. in many cases, we abuse work queues for things > that should really done from kthreads instead (basically anything that > takes more than a couple hundred microsecs or so). On that note does anyone have a problem is we manage the irq spawning safe kthreads the same way that we manage the work queue entries. i.e. by a structure allocated by the caller? Eric