mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@osdl.org>
Cc: Neela Syam Kolli <Neela.Kolli@engenio.com>,
	linux-scsi@vger.kernel.org, "Protasevich,
	Natalie" <Natalie.Protasevich@UNISYS.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH] megaraid: Use the proper type to hold the irq number.
Date: Mon, 07 Aug 2006 09:28:58 -0600	[thread overview]
Message-ID: <m1ejvsfttx.fsf@ebiederm.dsl.xmission.com> (raw)


When testing on a Unisys machine it was discovered that
the megaraid driver would not initialize as it was
requesting irq 162 instead of irq 1442 it was assigned.
The problem was the irq number had been truncated by being
stored in an unsigned char.

This patches fixes that problem and the driver now appears
to work.

The ioctl interface appears fundamentally broken as it exports
the irq number to user space in an unsigned char. 

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 drivers/scsi/megaraid/mega_common.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/megaraid/mega_common.h b/drivers/scsi/megaraid/mega_common.h
index 8cd0bd1..b50e27e 100644
--- a/drivers/scsi/megaraid/mega_common.h
+++ b/drivers/scsi/megaraid/mega_common.h
@@ -175,7 +175,7 @@ typedef struct {
 	uint8_t			max_lun;
 
 	uint32_t		unique_id;
-	uint8_t			irq;
+	int			irq;
 	uint8_t			ito;
 	caddr_t			ibuf;
 	dma_addr_t		ibuf_dma_h;
-- 
1.4.2.rc3.g7e18e


             reply	other threads:[~2006-08-07 15:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-07 15:28 Eric W. Biederman [this message]
2006-08-07 21:19 Ju, Seokmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ejvsfttx.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=Natalie.Protasevich@UNISYS.com \
    --cc=Neela.Kolli@engenio.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome