From: ebiederm@xmission.com (Eric W. Biederman)
To: "Prasanna Meda" <mlp@google.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: Comment about proc-dont-lock-task_structs-indefinitely.patch
Date: Tue, 11 Apr 2006 05:28:52 -0600 [thread overview]
Message-ID: <m1ek04bbbf.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <608a53b0604110348g22445b00u5ef57286eb230d58@mail.google.com> (Prasanna Meda's message of "Tue, 11 Apr 2006 16:18:48 +0530")
"Prasanna Meda" <mlp@google.com> writes:
> On 4/11/06, Prasanna Meda <mlp@google.com> wrote:
>
>>
>> The task decrement problem is fixed, but I think we have two more
>> problems in the following patch segment.
>>
>
> I think you agreed with the first problem. And the second problem is,
> show_map_internal is still treating m->private as task_struct instead
> of proc_maps_private.
Sorry my brain has been off thinking about a subtle
bug accidentally introduced in 2.6.17-rc1.
You are absolutely right. Somehow I missed the
fact that show_map_internal was using m->private.
Because get_gate_vma doesn't actually use it's argument
no bad behavior will result but that could change.
As for the seek case you may be right.
I have a cold that is beating on me, and I need to take a nap.
I remember looking at that closely and not seeing a problem,
but I have made mistakes before, and I'm not certain I recall
the seek case.
Eric
prev parent reply other threads:[~2006-04-11 11:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 19:42 Prasanna Meda
2006-04-11 10:48 ` Prasanna Meda
2006-04-11 11:28 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ek04bbbf.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlp@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome