mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] pid: Don't hash pid 0.
Date: Sat, 28 Jan 2006 23:31:26 -0700	[thread overview]
Message-ID: <m1ek2rfsu9.fsf@ebiederm.dsl.xmission.com> (raw)


pid 0 is never exported to userspace, so hashing it servers no useful
purpose.

Explicitly not hashing pid 0 allows struct pid to be marked as not
hashed, and it allows us to avoid checks if for pid 0 when searching
for processes to signal if pid 0 does not have a special meaning.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>


---

 kernel/pid.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

da30e3ccb4b506b79fe0e6439addbfc763e92e24
diff --git a/kernel/pid.c b/kernel/pid.c
index d2247dc..7890867 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -148,6 +148,9 @@ int fastcall attach_pid(task_t *task, en
 {
 	struct pid *pid, *task_pid;
 
+	if (!nr)
+		goto out;
+
 	task_pid = &task->pids[type];
 	pid = find_pid(type, nr);
 	task_pid->nr = nr;
@@ -159,7 +162,7 @@ int fastcall attach_pid(task_t *task, en
 		INIT_HLIST_NODE(&task_pid->pid_chain);
 		list_add_tail_rcu(&task_pid->pid_list, &pid->pid_list);
 	}
-
+ out:
 	return 0;
 }
 
@@ -169,6 +172,9 @@ static fastcall int __detach_pid(task_t 
 	int nr = 0;
 
 	pid = &task->pids[type];
+	if (!pid->nr)
+		goto out;
+
 	if (!hlist_unhashed(&pid->pid_chain)) {
 
 		if (list_empty(&pid->pid_list)) {
@@ -185,7 +191,7 @@ static fastcall int __detach_pid(task_t 
 
 	list_del_rcu(&pid->pid_list);
 	pid->nr = 0;
-
+ out:
 	return nr;
 }
 
-- 
1.1.5.g3480


             reply	other threads:[~2006-01-29  6:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-29  6:31 Eric W. Biederman [this message]
2006-01-29  8:33 ` Andrew Morton
2006-01-29 10:04   ` Eric W. Biederman
2006-01-30  9:29 ` Jan Engelhardt
2006-01-30  9:44   ` Yuki Cuss
2006-01-30  9:49     ` Jan Engelhardt
2006-01-30  9:58       ` Nigel Cunningham
2006-01-30 10:59 Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ek2rfsu9.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome