From: ebiederm@xmission.com (Eric W. Biederman)
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Kumar Gala <galak@kernel.crashing.org>,
Vivek Goyal <vgoyal@in.ibm.com>,
linux kernel mailing list <linux-kernel@vger.kernel.org>,
Fastboot mailing list <fastboot@lists.osdl.org>,
Morton Andrew Morton <akpm@osdl.org>,
gregkh@suse.de
Subject: Re: [RFC][PATCH] Expanding the size of "start" and "end" field in "struct resource"
Date: Wed, 15 Mar 2006 14:50:24 -0700 [thread overview]
Message-ID: <m1fylje5sv.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060315212841.GE25361@kvack.org> (Benjamin LaHaise's message of "Wed, 15 Mar 2006 16:28:41 -0500")
Benjamin LaHaise <bcrl@kvack.org> writes:
> On Wed, Mar 15, 2006 at 02:29:32PM -0700, Eric W. Biederman wrote:
>> If the impact is very slight or unmeasurable this means the option
>> needs to fall under CONFIG_EMBEDDED, where you can change if
>> every last bit of RAM counts but otherwise you won't care.
>
> But we have a data type that is correct for this usage: dma_addr_t.
Well the name is wrong. Because these are in general not DMA addresses,
but it may have the other desired properties. So it may be
useable.
>> Having > 32bit values on a 32bit platform is not the issue.
>>
>> Some drivers appear to puke simply because the value is 64bit. Which
>> means the driver will have problems on any 64bit kernel. That kind
>> of behavior is worth purging.
>
> Forcing it to be a 64 bit value doesn't fix that problem, so that isn't
> a valid excuse for adding bloat.
It doesn't fix it but it finds it. Which is half the battle. Once
the existing references are fixed up it makes it hard to introduce new
breakage like that, because more people see it.
As for bloat this assumes there will be some measurable bloat.
Resources are used in such a limited fashion I will be surprised if
you can measure any bloat.
Eric
next prev parent reply other threads:[~2006-03-15 21:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-15 19:31 Vivek Goyal
2006-03-15 19:48 ` Kumar Gala
2006-03-15 19:57 ` Arjan van de Ven
2006-03-15 20:01 ` Kumar Gala
2006-03-15 20:10 ` Kumar Gala
2006-03-15 20:13 ` Eric W. Biederman
2006-03-15 20:28 ` Kumar Gala
2006-03-15 20:37 ` Eric W. Biederman
2006-03-15 20:32 ` Vivek Goyal
2006-03-15 20:58 ` Eric W. Biederman
2006-03-15 21:57 ` David S. Miller
2006-03-15 20:53 ` Benjamin LaHaise
2006-03-15 21:05 ` Kumar Gala
2006-03-15 21:13 ` Benjamin LaHaise
2006-03-15 21:29 ` Eric W. Biederman
2006-03-15 21:28 ` Benjamin LaHaise
2006-03-15 21:50 ` Eric W. Biederman [this message]
2006-03-15 22:13 ` Andrew Morton
2006-03-15 22:18 ` David S. Miller
2006-03-15 21:59 ` Eric W. Biederman
2006-03-15 22:07 ` Benjamin LaHaise
2006-03-16 14:45 ` Eric W. Biederman
2006-03-15 21:30 ` Kumar Gala
2006-03-15 21:35 ` hackmiester / Hunter Fuller
2006-03-15 21:31 ` Eric W. Biederman
2006-03-15 21:15 ` Eric W. Biederman
2006-03-15 21:26 ` linux-os (Dick Johnson)
2006-03-15 21:37 ` Eric W. Biederman
2006-03-15 22:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1fylje5sv.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=bcrl@kvack.org \
--cc=fastboot@lists.osdl.org \
--cc=galak@kernel.crashing.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®