From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54159C433E0 for ; Tue, 23 Feb 2021 05:17:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F05D364E21 for ; Tue, 23 Feb 2021 05:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231300AbhBWFRl (ORCPT ); Tue, 23 Feb 2021 00:17:41 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:47946 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231202AbhBWFRj (ORCPT ); Tue, 23 Feb 2021 00:17:39 -0500 Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lEQ48-00ABIl-6P; Mon, 22 Feb 2021 22:16:56 -0700 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=fess.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lEQ47-003en1-Dn; Mon, 22 Feb 2021 22:16:55 -0700 From: ebiederm@xmission.com (Eric W. Biederman) To: Will Deacon Cc: james.morse@arm.com, jmorris@namei.org, tyhicks@linux.microsoft.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Pavel Tatashin , linux-kernel@vger.kernel.org, catalin.marinas@arm.com, kernel-team@android.com References: <20210219195142.13571-1-pasha.tatashin@soleen.com> <161399720788.2051103.17455817952511939013.b4-ty@kernel.org> Date: Mon, 22 Feb 2021 23:16:38 -0600 In-Reply-To: <161399720788.2051103.17455817952511939013.b4-ty@kernel.org> (Will Deacon's message of "Mon, 22 Feb 2021 14:29:01 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1lEQ47-003en1-Dn;;;mid=;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1/njm8oIeOFBiruLt6tVNkQHTfo43YCCvM= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH v2] kexec: move machine_kexec_post_load() to public interface X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Will Deacon writes: > On Fri, 19 Feb 2021 14:51:42 -0500, Pavel Tatashin wrote: >> machine_kexec_post_load() is called after kexec load is finished. It must >> declared in public header not in kexec_internal.h >> >> Fixes the following compiler warning: >> >> arch/arm64/kernel/machine_kexec.c:62:5: warning: no previous prototype for >> function 'machine_kexec_post_load' [-Wmissing-prototypes] >> int machine_kexec_post_load(struct kimage *kimage) > > Applied to arm64 (for-next/fixes), thanks! > > [1/1] kexec: move machine_kexec_post_load() to public interface > https://git.kernel.org/arm64/c/2596b6ae412b As you have already applied this it seems a bit late, but I will mention that change could legitimately have the following tag. Fixes: de68e4daea90 ("kexec: add machine_kexec_post_load()") So far arm64 is the only implementation of that hook. Eric