mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Andi Kleen <ak@suse.de>, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: Patch to make the head.S-must-be-first-in-vmlinux order explicit
Date: Fri, 24 Feb 2006 07:17:13 -0700	[thread overview]
Message-ID: <m1irr4deom.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <43FF0FE5.8040300@linux.intel.com> (Arjan van de Ven's message of "Fri, 24 Feb 2006 14:53:41 +0100")

Arjan van de Ven <arjan@linux.intel.com> writes:

> Eric W. Biederman wrote:
>> Andi Kleen <ak@suse.de> writes:
>>
>>> On Thursday 23 February 2006 14:57, Arjan van de Ven wrote:
>>>
>>>>> (or at least
>>>>> it shouldn't), but arch/x86_64/boot/compressed/head.S
>>>>> seems to have the entry address hardcoded. Perhaps you can just change this
>>>>> to pass in the right address?
>>>> the issue is that the address will be a link time thing, which means lots of
>>>> complexity.
>>> bzImage image should be only generated after vmlinux is done and then the
>>> address should be available with a simple grep in System.map
>> Andi it is more than that.  At least it was last I payed attention.
>> There are symbols like stext that various things depend on being early,
>> at least last time I looked.  So while it is doable it requires some
>> careful looking.
>
> _stext and such are very easy. That is actually not a real variable just a
> linker script thing, and since the reordering works on the linker script level
> that's already taken care of ;-)

It is currently a symbol defined in head.S though.  Not hard to fix
but the point is that there are a few subtle things.

> I've looked some yesterday at generating this at runtime, and haven't found a
> clean enough solution yet (esp one that doesn't break kdump); I'll keep poking
> at it for a bit more though....

I suspect the easy way to do this is to put a variable with the start location
either at the very start or the very end of the data that gets compressed that
has the address to jump to.  Once we uncompressed the data we can lookup
the pointer and jump to it.

Eric

  reply	other threads:[~2006-02-24 14:18 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-23 13:19 Arjan van de Ven
2006-02-23 13:42 ` Andi Kleen
2006-02-23 13:57   ` Arjan van de Ven
2006-02-23 14:14     ` Andi Kleen
2006-02-23 14:40       ` Arjan van de Ven
2006-02-24 13:49       ` Eric W. Biederman
2006-02-24 13:53         ` Arjan van de Ven
2006-02-24 14:17           ` Eric W. Biederman [this message]
2006-02-24 14:32           ` Andi Kleen
2006-02-23 15:09 ` Patch to reorder functions in the vmlinux to a defined order Arjan van de Ven
2006-02-23 16:00   ` Andi Kleen
2006-02-23 16:02     ` Arjan van de Ven
2006-02-23 16:43     ` Arjan van de Ven
2006-02-23 16:48       ` Andi Kleen
2006-02-23 16:49         ` Arjan van de Ven
2006-02-23 17:08       ` Linus Torvalds
2006-02-23 17:20         ` Andi Kleen
2006-02-23 17:34           ` Alan Cox
2006-02-23 18:13             ` Andi Kleen
2006-02-23 17:44           ` Linus Torvalds
2006-02-23 18:14             ` Andi Kleen
2006-02-23 19:03         ` linux-os (Dick Johnson)
2006-02-23 19:32           ` Linus Torvalds
2006-02-24 12:43             ` linux-os (Dick Johnson)
2006-02-23 19:23         ` Rene Herman
2006-02-23 19:31           ` Andi Kleen
2006-02-23 19:34           ` Alan Cox
2006-02-23 19:48             ` Rene Herman
2006-02-23 19:35           ` Linus Torvalds
2006-02-23 19:44             ` Arjan van de Ven
2006-02-23 20:13             ` Rene Herman
2006-02-23 20:26               ` Dave Jones
2006-02-24  2:44                 ` Fernando Luis Vazquez Cao
2006-02-24  2:47                   ` Andi Kleen
2006-02-24 14:44                   ` Theodore Ts'o
2006-02-23 23:19               ` Linus Torvalds
2006-02-23 23:53                 ` Rene Herman
2006-02-24 14:23                   ` Eric W. Biederman
2006-02-24 14:23                   ` Eric W. Biederman
2006-02-24 15:30                     ` Rene Herman
2006-02-24 15:55                       ` Eric W. Biederman
2006-02-24 16:48                         ` Andi Kleen
2006-02-24 20:38                           ` Eric W. Biederman
2006-02-25  2:11                             ` Folkert van Heusden
2006-02-25  8:32                               ` Arjan van de Ven
2006-02-24 17:26                         ` Linus Torvalds
2006-02-24 17:57                           ` Rene Herman
2006-02-24 18:11                             ` Linus Torvalds
2006-03-07 23:36                             ` H. Peter Anvin
2006-02-24 14:11                 ` Eric W. Biederman
2006-02-24  1:38             ` Martin Bligh
2006-02-23 20:07         ` Andy Whitcroft
2006-02-23 16:48   ` Linus Torvalds
2006-02-23 16:54     ` Benjamin LaHaise
2006-02-23 18:01     ` Arjan van de Ven
2006-02-23 16:57   ` linux-os (Dick Johnson)
2006-02-23 17:36   ` Zwane Mwaikambo
2006-02-23 17:59     ` Arjan van de Ven
2006-02-24 22:19   ` Tony Luck
2006-02-24 22:21     ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1irr4deom.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=arjan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome