mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: David Miller <davem@davemloft.net>
Cc: amwang@redhat.com, hooanon05@yahoo.co.jp, opurdila@ixiacom.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc_dointvec, write a single value
Date: Sun, 30 May 2010 08:09:02 -0700	[thread overview]
Message-ID: <m1k4qlh1f5.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20100525.161040.71125311.davem@davemloft.net> (David Miller's message of "Tue\, 25 May 2010 16\:10\:40 -0700 \(PDT\)")

David Miller <davem@davemloft.net> writes:

> From: Cong Wang <amwang@redhat.com>
> Date: Tue, 25 May 2010 20:23:47 +0800
>
>> On 05/25/10 14:49, J. R. Okajima wrote:
>>> The commit 00b7c3395aec3df43de5bd02a3c5a099ca51169f
>>> "sysctl: refactor integer handling proc code"
>>> modified the behaviour of writing to /proc.
>>> Before the commit, write("1\n") to /proc/sys/kernel/printk
>>> succeeded. But
>>> now it returns EINVAL.
>>>
>>> This commit supports writing a single value to a multi-valued entry.
>>>
>>> Signed-off-by: J. R. Okajima<hooanon05@yahoo.co.jp>
>> 
>> Reviewed-and-tested-by: WANG Cong <amwang@redhat.com>
>
> Since the regression causing change came in via the net tree
> I'll integrate this fix too, applied, thanks!

Thanks, guys for fixing this.

I hate to see my review comments show up like this in practice.
I had really hoped those unnecessary changes to proc would have
been dropped from that patchset.  Oh well.

Eric

      reply	other threads:[~2010-05-30 15:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24 14:32 proc_dointvec() and write J. R. Okajima
2010-05-25  4:49 ` Cong Wang
2010-05-25  4:57   ` J. R. Okajima
2010-05-25  5:35     ` Cong Wang
2010-05-25  6:49       ` [PATCH] proc_dointvec, write a single value J. R. Okajima
2010-05-25 12:23         ` Cong Wang
2010-05-25 23:10           ` David Miller
2010-05-30 15:09             ` Eric W. Biederman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1k4qlh1f5.fsf@fess.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=hooanon05@yahoo.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=opurdila@ixiacom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome