Re: [PATCH] x86: 64bit support more than 256 irq v2

[ebiederm@xmission.com (Eric W. Biederman)]

"Yinghai Lu" <yhlu.kernel@gmail.com> writes:

> On Fri, Aug 1, 2008 at 7:58 PM, Eric W. Biederman <ebiederm@xmission.com> wrote:
>> "Yinghai Lu" <yhlu.kernel@gmail.com> writes:
>>
>>> On Fri, Aug 1, 2008 at 7:02 PM, Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>>>> Dhaval Giani got:
>>>> kernel BUG at arch/x86/kernel/io_apic_64.c:357!
>>>> invalid opcode: 0000 [1] SMP
>>>> CPU 24
>>>> ...
>>>>
>>>> his system (x3950) has 8 ioapic, irq > 256
> ..
>>
>> There was a patch that came out a while ago that set NR_IRQS as NR_IOAPICS*32
> from
>> SGI.  Where that got to I don't recall.
>
> #ifdef CONFIG_X86_32
> # define MAX_IO_APICS 64
> #else
> # define MAX_IO_APICS 128
> # define MAX_LOCAL_APIC 32768
> #endif
>
> so they can take 128*32 = 4096?

Yes.  The real problem was just the complete explosion of irqs on SGI
machines that have paltry I/O to the outside world compared to their cpu
count.  Have 131072 irqs seemed a little much for them.

It is all a game of tuning heuristics right now, and if we can totally
kill NR_IRQS it all goes away.  But that is an issue to solve before
the next merge window not to kill the regression.

Eric