mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: + sysctl-error-on-bad-sysctl-tables.patch added to -mm tree
Date: Fri, 10 Aug 2007 03:22:23 -0600	[thread overview]
Message-ID: <m1k5s3zquo.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070810080952.GA6670@localhost.sw.ru> (Alexey Dobriyan's message of "Fri, 10 Aug 2007 12:09:52 +0400")

Alexey Dobriyan <adobriyan@sw.ru> writes:

> It gives false positive on kernel.pty.nr:
>
> 	sysctl table check failed: /kernel/pty/nr .1.62.2 No data
>
> However, ->data is set in unix98_pty_init().

It's a race.  

Data isn't set until after we enable the sysctl subsystem.

In practice I doubt it matters but I think would rather fix
that one case (by using register_sysctl_table) then not have
the check.

Eric

      reply	other threads:[~2007-08-10  9:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200708092211.l79MBoVR022139@imap1.linux-foundation.org>
2007-08-10  8:09 ` Alexey Dobriyan
2007-08-10  9:22   ` Eric W. Biederman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1k5s3zquo.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=adobriyan@sw.ru \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®