From: ebiederm@xmission.com (Eric W. Biederman)
To: michael@ellerman.id.au
Cc: linux-pci@atrey.karlin.mff.cuni.cz,
Greg Kroah-Hartman <greg@kroah.com>,
"David S. Miller" <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
daniel.e.wolstenholme@intel.com
Subject: Re: [PATCH 9/21] MSI: Expand pci_msi_supported()
Date: Tue, 27 Mar 2007 23:30:39 -0600 [thread overview]
Message-ID: <m1k5x2rl34.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <1175058070.6386.12.camel@concordia.ozlabs.ibm.com> (Michael Ellerman's message of "Wed, 28 Mar 2007 15:01:10 +1000")
On another thought if we want to keep the return code we should
probably rename it pci_msi_verify(). Or something like that
so it is clear we are not asking if it is supported a question
with a boolean answer. But merely verifying that it is supported.
At which point if the verification function fails it would
be expected to return an error code, and we could then be
expected to propagate when we receive it.
Eric
prev parent reply other threads:[~2007-03-28 5:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070322105340.53827DDF65@ozlabs.org>
2007-03-28 4:45 ` Eric W. Biederman
2007-03-28 5:01 ` Michael Ellerman
2007-03-28 5:20 ` Eric W. Biederman
2007-03-28 5:39 ` Michael Ellerman
2007-03-28 5:30 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1k5x2rl34.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=daniel.e.wolstenholme@intel.com \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome