From: ebiederm@xmission.com (Eric W. Biederman)
To: Christoph Hellwig <hch@infradead.org>
Cc: merlin@sztaki.hu, linux-kernel@vger.kernel.org
Subject: Re: question about kill PIDTYPE_TGID patch
Date: Fri, 11 Aug 2006 07:58:56 -0600 [thread overview]
Message-ID: <m1lkpvz84f.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060809112922.GA15224@infradead.org> (Christoph Hellwig's message of "Wed, 9 Aug 2006 12:29:22 +0100")
Christoph Hellwig <hch@infradead.org> writes:
> On Wed, Aug 09, 2006 at 01:23:12PM +0200, merlin@sztaki.hu wrote:
>> Hello,
>>
>> I'm trying to compile IBM GPFS(2.3.0-15) Portability Layer with a 2.6.16
>> kernel (2.6.16-1.2289_FC6-xen-i686). The compiler stops with
>> the error message below:
>>
>> kdump-kern.c:163: error: `PIDTYPE_TGID' undeclared (first use in this
>> function)
>>
>> As I think, this is because of the PIDTYPE_TGID patch.
>>
>> I don't want to get out that patch from the kernel , if there's
>> a more simple solution.
>>
>> I hope you can suggest me a solution for the three lines where PIDTYPE_TGID
>> appears (see below) in the source code.
>
> Just stop using broken, propritary out of tree code. If you refuse to
> do that go to your IBM support contact and whine to them, it's their fault
> after all.
What makes this very funny is that if the GPFS code had called the appropriate
function it would not have broken. The appropriate function is the same
in 2.4.x as it is in 2.6.
Eric
prev parent reply other threads:[~2006-08-11 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 11:23 merlin
2006-08-09 11:29 ` Christoph Hellwig
2006-08-11 13:58 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1lkpvz84f.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=merlin@sztaki.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®