From: ebiederm@xmission.com (Eric W. Biederman)
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Pavel Emelyanov <xemul@openvz.org>,
Daniel Hokka Zakrisson <daniel@hozac.com>,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/2] signals: kill(-1) should only signal processes in the same namespace
Date: Thu, 17 Jul 2008 10:50:56 -0700 [thread overview]
Message-ID: <m1mykgv1q7.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <20080717173254.GA20948@tv-sign.ru> (Oleg Nesterov's message of "Thu, 17 Jul 2008 21:32:54 +0400")
Oleg Nesterov <oleg@tv-sign.ru> writes:
> kill_something_info() can't walk threads, think about the realtime signals.
walking threads is fine delivering signals to non thread group leaders is
a problem.
> Anyway, I think we should change kill_something_info(-1) to use rcu_read_lock()
> instead of tasklist.
Being dense I think the locking implications of a correct implementation are more
then we are ready to deal with to fix this bug. Although I remember discussing
it and seeing something reasonable.
Eric
next prev parent reply other threads:[~2008-07-17 17:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 14:55 Daniel Hokka Zakrisson
2008-07-17 15:01 ` Pavel Emelyanov
2008-07-17 15:24 ` Daniel Hokka Zakrisson
2008-07-17 15:54 ` Pavel Emelyanov
2008-07-17 17:32 ` Oleg Nesterov
2008-07-17 17:50 ` Eric W. Biederman [this message]
2008-07-17 17:45 ` Eric W. Biederman
2008-07-17 18:39 ` Daniel Hokka Zakrisson
2008-07-17 18:45 ` Eric W. Biederman
2008-07-17 18:13 ` sukadev
2008-07-17 18:44 ` Daniel Hokka Zakrisson
2008-07-17 18:46 ` Eric W. Biederman
2008-07-23 14:34 ` Oleg Nesterov
2008-07-23 16:09 ` Daniel Hokka Zakrisson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1mykgv1q7.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=daniel@hozac.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome