From: ebiederm@xmission.com (Eric W. Biederman)
To: "Huang, Ying" <ying.huang@intel.com>
Cc: ak@suse.de, akpm@linux-foundation.org,
Yinghai Lu <yhlu.kernel@gmail.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Chandramouli Narayanan <mouli@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] x86_64 EFI support -v3
Date: Mon, 30 Jul 2007 22:47:14 -0600 [thread overview]
Message-ID: <m1myxdtc19.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <1185851569.23149.25.camel@caritas-dev.intel.com> (Ying Huang's message of "Tue, 31 Jul 2007 11:12:49 +0800")
"Huang, Ying" <ying.huang@intel.com> writes:
> Looking forward to your comments,
After reading through the patches. I don't see any compelling
reason to use the efi runtime support. It looks like we get
the interesting support for efi without out. The graphics
and the memory map. We have ACPI which already can do handle
this case.
Further the code has dead code sitting in the patches that you never
intend to use. EFI_MEMMAP.
The boot protocols are now out of sync for arch/i386 and arch/x86_64
for no obvious reason.
Using efi_set_virtual means kdump doesn't work which means that no
one is going to use this in a prebuilt kernel.
So mostly this patchset looks like a bad idea.
Eric
next prev parent reply other threads:[~2007-07-31 4:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 3:12 Huang, Ying
2007-07-31 4:16 ` Eric W. Biederman
2007-07-31 8:55 ` Huang, Ying
2007-08-01 17:21 ` Eric W. Biederman
2007-07-31 4:47 ` Eric W. Biederman [this message]
2007-08-06 5:40 ` Huang, Ying
2007-08-08 16:45 ` Eric W. Biederman
2007-08-08 20:41 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1myxdtc19.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mouli@linux.intel.com \
--cc=randy.dunlap@oracle.com \
--cc=yhlu.kernel@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome