Re: [2.6 patch] HT_IRQ must depend on PCI

[ebiederm@xmission.com (Eric W. Biederman)]

Adrian Bunk <bunk@stusta.de> writes:

Looks good to me.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>

> CONFIG_PCI=n, CONFIG_HT_IRQ=y results in the following compile error:
>
> <--  snip  -->
>
> ...
>   LD      vmlinux
> arch/i386/mach-generic/built-in.o: In function `apicid_to_node':
> summit.c:(.text+0x53): undefined reference to `apicid_2_node'
> arch/i386/kernel/built-in.o: In function `arch_setup_ht_irq':
> (.text+0xcf79): undefined reference to `write_ht_irq_low'
> arch/i386/kernel/built-in.o: In function `arch_setup_ht_irq':
> (.text+0xcf85): undefined reference to `write_ht_irq_high'
> arch/i386/kernel/built-in.o: In function `k7nops':
> alternative.c:(.data+0x1358): undefined reference to `mask_ht_irq'
> alternative.c:(.data+0x1360): undefined reference to `unmask_ht_irq'
> make[1]: *** [vmlinux] Error 1
>
> <--  snip  -->
>
> Bug report by Jesper Juhl.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6/drivers/pci/Kconfig.old	2006-10-08 05:55:51.000000000 +0200
> +++ linux-2.6/drivers/pci/Kconfig	2006-10-08 05:56:14.000000000 +0200
> @@ -55,7 +55,7 @@
>  config HT_IRQ
>  	bool "Interrupts on hypertransport devices"
>  	default y
> -	depends on X86_LOCAL_APIC && X86_IO_APIC
> +	depends on PCI && X86_LOCAL_APIC && X86_IO_APIC
>  	help
>  	   This allows native hypertransport devices to use interrupts.
>