From: ebiederm@xmission.com (Eric W. Biederman)
To: Jesper Juhl <jj@chaosbits.net>
Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Nick Piggin <npiggin@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] sysctl: remove impossible condition check
Date: Sat, 11 Jun 2011 23:02:41 -0700 [thread overview]
Message-ID: <m1pqmj37um.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1106100955280.19998@swampdragon.chaosbits.net> (Jesper Juhl's message of "Fri, 10 Jun 2011 09:56:18 +0200 (CEST)")
Jesper Juhl <jj@chaosbits.net> writes:
> On Fri, 10 Jun 2011, Lucas De Marchi wrote:
>
>> Remove checks for conditions that will never happen. If procname is NULL
>> the loop would already had bailed out, so there's no need to check it
>> again.
>>
>> At the same time this also compacts the function find_in_table() by
>> refactoring it to be easier to read.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
>
> Looks good to me.
>
> Reviewed-by: Jesper Juhl <jj@chaosbits.net>
Applied thanks all.
Eric
prev parent reply other threads:[~2011-06-12 6:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 13:15 Lucas De Marchi
2011-06-01 13:25 ` Jesper Juhl
2011-06-01 14:11 ` Lucas De Marchi
2011-06-02 13:40 ` Eric W. Biederman
2011-06-02 13:51 ` Lucas De Marchi
2011-06-02 16:00 ` Lucas De Marchi
[not found] ` <1307684165-14742-1-git-send-email-lucas.demarchi@profusion.mobi>
2011-06-10 7:56 ` Jesper Juhl
2011-06-12 6:02 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1pqmj37um.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=npiggin@kernel.dk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®