From: ebiederm@xmission.com (Eric W. Biederman)
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: sync_tsc fix the race (so we can boot)
Date: Fri, 29 Jul 2005 10:04:48 -0600 [thread overview]
Message-ID: <m1pst14mzj.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20050729074419.GB3726@bragg.suse.de> (Andi Kleen's message of "Fri, 29 Jul 2005 09:44:19 +0200")
Andi Kleen <ak@suse.de> writes:
> On Wed, Jul 27, 2005 at 10:03:04PM -0600, Eric W. Biederman wrote:
>> I believe this patch suffers from apicid versus logical cpu number confusion.
>> I copied the basic logic from smp_send_reschedule and I can't find where
>> that translates from the logical cpuid to apicid. So it isn't quite
>> correct yet. It should be close enough that it shouldn't be too hard
>> to finish it up.
>>
>> More bug fixes after I have slept but I figured I needed to get this
>> one out for review.
>
> Thanks looks good. This should fix the unexplained
> hang for various people. Logical<->apicid is actually ok, the low
> level _mask function takes care of that (it differs depending on the
> APIC mode anyways)
I guess my confusion comes from looking at the code in flat_send_IPI_mask.
cpus_addr(mask)[0] reduces it to just the first word but I don't
see any translation being done.
Eric
prev parent reply other threads:[~2005-07-29 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-28 4:03 Eric W. Biederman
2005-07-28 16:22 ` yhlu
2005-07-28 17:10 ` [PATCH] x86_64 : prefetchw() can fall back to prefetch() if !3DNOW Eric Dumazet
2005-08-03 13:17 ` Andi Kleen
2005-07-28 17:35 ` [PATCH] x86_64: sync_tsc fix the race (so we can boot) yhlu
2005-07-29 3:08 ` Eric W. Biederman
2005-07-29 20:41 ` yhlu
2005-07-29 23:27 ` yhlu
2005-07-30 0:40 ` Eric W. Biederman
2005-07-30 0:52 ` yhlu
2005-07-30 1:45 ` yhlu
2005-07-29 7:44 ` Andi Kleen
2005-07-29 15:52 ` Eric W. Biederman
2005-07-29 16:04 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1pst14mzj.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®