From: ebiederm@xmission.com (Eric W. Biederman)
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Andi Kleen <ak@suse.de>,
Chandramouli Narayanan <mouli@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support
Date: Thu, 25 Oct 2007 10:55:44 -0600 [thread overview]
Message-ID: <m1r6jj5e27.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <alpine.LFD.0.9999.0710251800250.3186@localhost.localdomain> (Thomas Gleixner's message of "Thu, 25 Oct 2007 18:09:49 +0200 (CEST)")
Thomas Gleixner <tglx@linutronix.de> writes:
> On Thu, 25 Oct 2007, Huang, Ying wrote:
>
>> This patch adds basic runtime services support for EFI x86_64
>> system. The main file of the patch is the addition of efi.c for
>> x86_64. This file is modeled after the EFI IA32 avatar.
>
> modeled means copied and modified, right?
>
> This is wrong. I compared efi_32.c and efi_64.c and a large amount of
> the code is simply the same. The small details can be sorted out by
> two sets of macros/inline functions easily.
>
> Please fix this up.
I don't think there is a compelling case for us to use any efi
services at this time so unification should be easy:
rm arch/x86/kernel/efi_32.c arch/x86/kernel/efi_stub_32.c
Especially for accessing the real time clock that has a well
defined hardware interface going through efi an additional
software emulation layer looks like asking for trouble.
Eric
next prev parent reply other threads:[~2007-10-25 16:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 6:57 Huang, Ying
2007-10-25 16:09 ` Thomas Gleixner
2007-10-25 16:28 ` H. Peter Anvin
2007-10-25 16:55 ` Eric W. Biederman [this message]
2007-10-25 16:56 ` Arjan van de Ven
2007-10-25 17:05 ` H. Peter Anvin
2007-10-25 17:39 ` Eric W. Biederman
2007-10-25 17:51 ` H. Peter Anvin
2007-10-25 18:04 ` Eric W. Biederman
2007-10-25 20:36 ` H. Peter Anvin
2007-10-25 22:20 ` Eric W. Biederman
2007-10-25 22:29 ` H. Peter Anvin
2007-10-26 2:31 ` Huang, Ying
2007-10-26 2:14 ` Huang, Ying
2007-10-25 17:06 ` Eric W. Biederman
2007-10-26 1:28 ` Huang, Ying
2007-10-25 17:06 ` Andi Kleen
2007-10-25 17:08 ` H. Peter Anvin
2007-10-25 17:30 ` Eric W. Biederman
2007-10-26 2:12 ` Huang, Ying
2007-10-26 1:03 ` Huang, Ying
2007-10-26 8:48 ` Thomas Gleixner
2007-10-26 9:30 ` Huang, Ying
2007-10-26 10:20 ` Thomas Gleixner
2007-10-26 11:37 ` Andi Kleen
2007-10-26 11:31 ` Alan Cox
2007-10-26 17:00 ` H. Peter Anvin
2007-10-29 1:05 ` Huang, Ying
2007-10-26 3:36 ` Huang, Ying
2007-10-26 4:11 ` H. Peter Anvin
2007-10-25 17:01 ` Eric W. Biederman
2007-10-26 1:17 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1r6jj5e27.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mouli@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome