From: ebiederm@xmission.com (Eric W. Biederman)
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
garloff@suse.de, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] KERN_SETUID_DUMPABLE in /proc/sys/fs/
Date: Sun, 12 Mar 2006 15:07:47 -0700 [thread overview]
Message-ID: <m1r757xqoc.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <1142064294.3055.13.camel@laptopd505.fenrus.org> (Arjan van de Ven's message of "Sat, 11 Mar 2006 09:04:54 +0100")
Arjan van de Ven <arjan@infradead.org> writes:
>
> diff -purN linux-2.6.16-rc5/include/linux/sysctl.h
> linux-2.6.16-rc5-setuid/include/linux/sysctl.h
> --- linux-2.6.16-rc5/include/linux/sysctl.h 2006-02-27 09:13:31.000000000 +0100
> +++ linux-2.6.16-rc5-setuid/include/linux/sysctl.h 2006-03-11 09:02:13.000000000
> +0100
> @@ -144,7 +144,6 @@ enum
> KERN_UNKNOWN_NMI_PANIC=66, /* int: unknown nmi panic flag */
> KERN_BOOTLOADER_TYPE=67, /* int: boot loader type */
> KERN_RANDOMIZE=68, /* int: randomize virtual address space */
> - KERN_SETUID_DUMPABLE=69, /* int: behaviour of dumps for setuid core */
> KERN_SPIN_RETRY=70, /* int: number of spinlock retries */
> KERN_ACPI_VIDEO_FLAGS=71, /* int: flags for setting up video after ACPI
> sleep */
> };
> @@ -759,6 +758,9 @@ enum
> FS_AIO_NR=18, /* current system-wide number of aio requests */
> FS_AIO_MAX_NR=19, /* system-wide maximum number of aio requests */
> FS_INOTIFY=20, /* inotify submenu */
> + /* Note: the following got misplaced but this mistake is
> + now part of the ABI */
> + FS_SETUID_DUMPABLE=21, /* int: behaviour of dumps for setuid core */
This must be number 69 here. Or else we break the sys_sysctl ABI.
> };
>
Eric
next prev parent reply other threads:[~2006-03-12 22:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-10 15:57 Kurt Garloff
2006-03-10 22:56 ` Andrew Morton
2006-03-11 7:23 ` Arjan van de Ven
2006-03-11 7:41 ` Andrew Morton
2006-03-11 7:47 ` Arjan van de Ven
2006-03-11 7:51 ` Andrew Morton
2006-03-11 8:04 ` Arjan van de Ven
2006-03-11 12:09 ` Jan Engelhardt
2006-03-12 22:07 ` Eric W. Biederman [this message]
2006-03-12 22:32 ` Kurt Garloff
2006-03-12 23:39 ` Eric W. Biederman
2006-03-13 8:00 ` Arjan van de Ven
2006-03-13 15:06 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1r757xqoc.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=garloff@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome