mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Shani Moideen <shani.moideen@wipro.com>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	kernel-janitors@lists.osdl.org
Subject: Re: [KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/kernel/machine_kexec.c
Date: Mon, 11 Jun 2007 23:32:03 -0600	[thread overview]
Message-ID: <m1vedtpwks.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <1181616342.2282.8.camel@shani-win> (Shani Moideen's message of "Tue, 12 Jun 2007 08:15:41 +0530")

Shani Moideen <shani.moideen@wipro.com> writes:

> Hi,
> Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in
> arch/i386/kernel/machine_kexec.c.

Please no.

People get creative in copy_page (especially mmx_copy_page),
and this code path need something simple and stupid, that
will work every time, especially when things are messed up
elsewhere.

Ideally we would actually do all of the setup before this point.
but that is another issue entirely.

Eric

  reply	other threads:[~2007-06-12  5:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-12  2:45 Shani Moideen
2007-06-12  5:32 ` Eric W. Biederman [this message]
2007-06-12 16:52   ` H. Peter Anvin
2007-06-13 19:46     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1vedtpwks.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shani.moideen@wipro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome