From: ebiederm@xmission.com (Eric W. Biederman)
To: "Brown, Len" <len.brown@intel.com>
Cc: "Pierre Ossman" <drzeus-list@drzeus.cx>,
<ncunningham@cyclades.com>, "Pavel Machek" <pavel@ucw.cz>,
"Meelis Roos" <mroos@linux.ee>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: reboot vs poweroff
Date: Thu, 01 Sep 2005 22:43:17 -0600 [thread overview]
Message-ID: <m1vf1knkpm.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <F7DC2337C7631D4386A2DF6E8FB22B30047B8DAF@hdsmsx401.amr.corp.intel.com> (Len Brown's message of "Thu, 1 Sep 2005 14:23:31 -0400")
"Brown, Len" <len.brown@intel.com> writes:
>
>>Patch tested and works fine here. You should probably make a
>>note in the bugzilla so we don't get a conflicting merge
>>from the ACPI folks.
>
> One might also consider that it would be a good idea to
> send patches that break ACPI files to the ACPI maintainer
> and acpi-devel@lists.sourceforge.net before sending them
> to Linus...
My apologies, for bug fixes that are not complete and simply move
where the bug is. My apologies also for not cc'ing you, I didn't
intend to omit you but it never occurred to me. The patch was
also 2 lines and obviously correct.
For this round I knew you were on the CC list and deliberately included
you.
My goal for the reboot/halt/suspend/kexec path is to fix it so the
generic code is correct and consistent. Something it hasn't been for
years creating the affect that a correct bug fix in one place would
break something else.
Until the reboot paths are correct and consistent things will continue
to break, in weird and unpredictable ways, that will keep us all
hunting weird strange bugs for a long time. I think the S4 suspend
case is the last code path that needs to be fixed. It is certainly
the last one I am aware of.
Eric
next prev parent reply other threads:[~2005-09-02 4:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-01 18:23 Brown, Len
2005-09-02 4:43 ` Eric W. Biederman [this message]
2005-09-10 21:07 ` Eric W. Biederman
2005-09-11 8:43 ` Meelis Roos
2005-09-11 8:53 ` Eric W. Biederman
2005-09-20 17:42 ` [PATCH 1/2] reboot: Comment and factor the main reboot functions Eric W. Biederman
2005-09-20 17:49 ` [PATCH 2/2] suspend: Cleanup calling of power off methods Eric W. Biederman
2005-09-20 21:06 ` Pavel Machek
2005-09-21 2:08 ` Eric W. Biederman
2005-09-21 10:18 ` Pavel Machek
2005-09-21 13:50 ` Eric W. Biederman
2005-09-21 16:35 ` Linus Torvalds
2005-09-21 17:28 ` Eric W. Biederman
2005-09-21 18:02 ` Andrew Morton
2005-09-21 17:36 ` Alexander Nyberg
2005-09-21 18:15 ` Andrew Morton
2005-09-21 19:45 ` Hugh Dickins
2005-09-21 18:35 ` Diego Calleja
2005-09-21 18:49 ` Andrew Morton
2005-09-21 19:54 ` Martin J. Bligh
2005-09-26 12:09 ` Diego Calleja
2005-09-26 13:47 ` Martin J. Bligh
2005-09-21 20:16 ` Diego Calleja
2005-09-21 19:43 ` Russell King
2005-09-21 20:10 ` Andrew Morton
2005-09-22 7:15 ` Pierre Ossman
2005-09-22 8:10 ` [ACPI] " Rafael J. Wysocki
2005-09-22 9:30 ` Eric W. Biederman
2005-09-22 9:38 ` Russell King
2005-09-22 10:54 ` Pierre Ossman
2005-09-21 17:46 ` Andrew Morton
2005-09-21 18:08 ` Eric W. Biederman
2005-09-21 18:24 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2005-09-01 6:24 reboot vs poweroff (was: Linux 2.6.13) Meelis Roos
2005-09-01 6:48 ` Nigel Cunningham
2005-09-01 7:33 ` Meelis Roos
2005-09-01 12:32 ` Pierre Ossman
2005-09-01 12:48 ` Nigel Cunningham
2005-09-01 15:15 ` Eric W. Biederman
2005-09-01 15:19 ` reboot vs poweroff Pierre Ossman
2005-09-01 17:00 ` Eric W. Biederman
2005-09-01 18:19 ` Pierre Ossman
2005-09-01 18:23 ` Eric W. Biederman
2005-09-01 21:11 ` Nigel Cunningham
2005-09-02 4:46 ` Eric W. Biederman
2005-09-01 20:22 ` Pavel Machek
2005-09-02 4:26 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1vf1knkpm.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=drzeus-list@drzeus.cx \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=ncunningham@cyclades.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome