From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756427Ab2DXCke (ORCPT ); Mon, 23 Apr 2012 22:40:34 -0400 Received: from out01.mta.xmission.com ([166.70.13.231]:33030 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756258Ab2DXCkc (ORCPT ); Mon, 23 Apr 2012 22:40:32 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: "Serge E. Hallyn" Cc: linux-kernel@vger.kernel.org, Linux Containers , Cyrill Gorcunov , linux-security-module@vger.kernel.org, Al Viro , linux-fsdevel@vger.kernel.org, Andrew Morton , Linus Torvalds References: <1333862139-31737-33-git-send-email-ebiederm@xmission.com> <20120418191033.GL5186@mail.hallyn.com> Date: Mon, 23 Apr 2012 19:44:36 -0700 In-Reply-To: <20120418191033.GL5186@mail.hallyn.com> (Serge E. Hallyn's message of "Wed, 18 Apr 2012 19:10:33 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in02.mta.xmission.com;;;ip=98.207.153.68;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+kC9SGtztmfQmEiDeXAfThvdBZ6AZTOPs= X-SA-Exim-Connect-IP: 98.207.153.68 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.1 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: T_TM2_M_HEADER_IN_MSG * -3.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] * 2.2 XMSubMetaSxObfu_03 Obfuscated Sexy Noun-People * 0.0 T_XMDrugObfuBody_08 obfuscated drug references * 1.6 XMSubMetaSx_00 1+ Sexy Words X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;"Serge E. Hallyn" X-Spam-Relay-Country: Subject: Re: [PATCH 33/43] userns: Convert binary formats to use kuid/kgid where appropriate X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Fri, 06 Aug 2010 16:31:04 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Serge E. Hallyn" writes: > Quoting Eric W. Beiderman (ebiederm@xmission.com): >> From: Eric W. Biederman >> >> Signed-off-by: Eric W. Biederman > > Ok I'll spare the list the traffic - for patches 33-43, > > Acked-by: Serge Hallyn I noticed one other significant gotcha with my changes. Code that has not been converted and needs to be converted fails to build with type errors. -- Good. Code that has not been converted and needs to be converted is still selectable in make config. -- Bad make oldmodconfig -- fails with type errors unless everything is converted Bad. So I am adding/debugging an additional patch that will catch these failure in Kconfig so people don't get nasty surprises. Eric