From: ebiederm@xmission.com (Eric W. Biederman)
To: Cal Peake <cp@absolutedigital.net>
Cc: Andrew Morton <akpm@osdl.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Randy Dunlap <rdunlap@xenotime.net>,
Jan Beulich <jbeulich@novell.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Undeprecate the sysctl system call
Date: Tue, 17 Oct 2006 21:41:19 -0600 [thread overview]
Message-ID: <m1wt6y70kg.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0610171853160.25484@lancer.cnet.absolutedigital.net> (Cal Peake's message of "Tue, 17 Oct 2006 19:09:02 -0400 (EDT)")
Cal Peake <cp@absolutedigital.net> writes:
> On Tue, 17 Oct 2006, Andrew Morton wrote:
>
>> yes, it appears that we screwed that up, but I haven't got around to thinking
> about
>> it yet.
>
> Well, here's a patch that hopefully solves the mess :)
>
> From: Cal Peake <cp@absolutedigital.net>
>
> Undeprecate the sysctl system call and default to always include it with
> the option for embedded folks to exclude it. Also, remove it's entry from
> the feature removal file.
>
> Signed-off-by: Cal Peake <cp@absolutedigital.net>
NAK on the grounds that it does not fix the related wording in sysctl.h
As for the rest of this I disagree with this direction as it is not
fixing the status quo, just attempting to maintain it.
The status quo is that there is one ridiculous user in glibc that
doesn't break when sys_sysctl is not compiled in.
The status quo is that we don't properly maintain sysctl.h and we arbitrarily
change the numbers.
The status quo is that sys_sysctl has been deprecated for longer than
feature-removal.txt
If we choose to maintain this and step up to maintaining the binary
ABI which no one uses then I am happy.
If we agree to remove the useless thing I am also happy.
It is wrong to maintain the status quo. Who is volunteering to step
up to the plate and maintain this thing?
I have just about enough time and energy to finish killing sys_sysctl.
Contrary to Alan's assertion all of those binary numbers in sysctl.h
are not trivial to maintain or we would not have broken the ABI
several times in the 2.6 series. Although I do agree it should be
simple (not trivial) to maintain if we decide it is important.
Eric
next prev parent reply other threads:[~2006-10-18 3:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 15:59 config SYSCTL_SYSCALL Jan Beulich
2006-10-17 16:19 ` Randy Dunlap
2006-10-17 18:17 ` [PATCH] Restore sysctl syscall option for non-embedded users Cal Peake
2006-10-17 22:11 ` Alan Cox
2006-10-17 21:59 ` Cal Peake
2006-10-17 22:00 ` Andrew Morton
2006-10-17 23:09 ` [PATCH] Undeprecate the sysctl system call Cal Peake
2006-10-17 23:19 ` Alan Cox
2006-10-18 3:41 ` Eric W. Biederman [this message]
2006-10-18 11:02 ` Alan Cox
2006-10-18 11:33 ` Andi Kleen
2006-10-18 12:15 ` Alan Cox
2006-10-18 12:41 ` Andi Kleen
2006-10-18 12:59 ` Alan Cox
2006-10-18 13:08 ` Andi Kleen
2006-10-18 16:20 ` [PATCHv2] " Cal Peake
2006-10-18 16:28 ` Andi Kleen
2006-10-18 16:41 ` Alan Cox
2006-10-18 19:31 ` Andrew Morton
2006-10-18 22:13 ` Alan Cox
2006-10-19 15:09 ` [PATCH] " Eric W. Biederman
2006-10-19 16:35 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1wt6y70kg.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cp@absolutedigital.net \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome