From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764444AbXLTXFy (ORCPT ); Thu, 20 Dec 2007 18:05:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752489AbXLTXFn (ORCPT ); Thu, 20 Dec 2007 18:05:43 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:50146 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762168AbXLTXFm (ORCPT ); Thu, 20 Dec 2007 18:05:42 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: "Jan Beulich" Cc: Subject: Re: [PATCH] constify tables in kernel/sysctl_check.c References: <476A73A3.76E4.0078.0@novell.com> Date: Thu, 20 Dec 2007 16:05:28 -0700 In-Reply-To: <476A73A3.76E4.0078.0@novell.com> (Jan Beulich's message of "Thu, 20 Dec 2007 12:52:35 +0000") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Jan Beulich" writes: > Remains the question whether it is intended that many, perhaps even > large, tables are compiled in without ever having a chance to get used, > i.e. whether there shouldn't #ifdef CONFIG_xxx get added. The constification looks good. The file should be compiled only when we have sysctl support. We use those tables when we call register_sysctl_table. Which we do a lot. Eric