From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754827AbXLAUyc (ORCPT ); Sat, 1 Dec 2007 15:54:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752220AbXLAUyU (ORCPT ); Sat, 1 Dec 2007 15:54:20 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:35946 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbXLAUyT (ORCPT ); Sat, 1 Dec 2007 15:54:19 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Mark Lord Cc: Stephen Hemminger , Alan Cox , Greg Kroah-Hartman , Greg KH , Tejun Heo , Linux Containers , netdev@vger.kernel.org, cornelia.huck@de.ibm.com, stern@rowland.harvard.edu, kay.sievers@vrfy.org, linux-kernel@vger.kernel.org, Andrew Morton , Herbert Xu , David Miller , Linus Torvalds Subject: Re: namespace support requires network modules to say "GPL" References: <47515D39.9030900@rtr.ca> <20071201111736.297dd99a@freepuppy.rosehill> <20071201192341.6750fbdb@the-village.bc.nu> <20071201113815.5df0960a@freepuppy.rosehill> <4751C238.6010609@rtr.ca> Date: Sat, 01 Dec 2007 13:52:05 -0700 In-Reply-To: <4751C238.6010609@rtr.ca> (Mark Lord's message of "Sat, 01 Dec 2007 15:21:12 -0500") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Lord writes: >>> Can we get this resolved before 2.6.24 is released? Going back and forth >>> on API's is just needless frottage. >> >> Sure. We keep the updated dev_get_by_XXXX that takes a network >> namespace parameter. > .. > > And what should code be passing in when "# CONFIG_NET_NS is not set" ? Mostly CONFIG_NET_NS is a define to keep us from exposing the feature to user space not to remove the code impact. People could not stand the look of the code that would actually allow us to compile everything out. So all of the struct net * fields remain when !CONFIG_NET_NS. Including the global variable init_net. Eric