mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Andrew Morton <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>, <fastboot@osdl.org>
Subject: [PATCH] i386 kexec:  Allow the kexec on panic support to compile on voyager.
Date: Mon, 10 Jul 2006 16:37:49 -0600	[thread overview]
Message-ID: <m1y7v1krwi.fsf@ebiederm.dsl.xmission.com> (raw)


This patch removes the foolish assumption that SMP implied local
apics.  That assumption is not-true on the Voyager subarch.  This
makes that dependency explicit, and allows the code to build.

What gets disabled is just an optimization to get better crash
dumps so the support should work if there is a kernel that will
initialization on the voyager subarch under those harsh conditions.

Hopefully we can figure out how to initialize apics in init_IRQ
and remove the need to disable io_apics and this dependency.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 arch/i386/kernel/crash.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/i386/kernel/crash.c b/arch/i386/kernel/crash.c
index f10da80..67d297d 100644
--- a/arch/i386/kernel/crash.c
+++ b/arch/i386/kernel/crash.c
@@ -92,7 +92,7 @@ static void crash_save_self(struct pt_re
 	crash_save_this_cpu(regs, cpu);
 }
 
-#ifdef CONFIG_SMP
+#if defined(CONFIG_SMP) && defined(CONFIG_X86_LOCAL_APIC)
 static atomic_t waiting_for_crash_ipi;
 
 static int crash_nmi_callback(struct notifier_block *self,
-- 
1.4.1.gac83a


             reply	other threads:[~2006-07-10 22:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10 22:37 Eric W. Biederman [this message]
2006-07-11 12:30 ` Horms
2006-07-11 20:07   ` Eric W. Biederman
2006-07-12  1:00     ` Horms
2006-07-12  6:09       ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1y7v1krwi.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=akpm@osdl.org \
    --cc=fastboot@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®