From: ebiederm@xmission.com (Eric W. Biederman)
To: Andi Kleen <ak@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, fastboot@osdl.org
Subject: Re: [PATCH 1/2] x86_64 nmi_watchdog: Make check_nmi_watchdog static
Date: Tue, 04 Oct 2005 09:26:45 -0600 [thread overview]
Message-ID: <m1y859716y.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <200510041721.09736.ak@suse.de> (Andi Kleen's message of "Tue, 4 Oct 2005 17:21:09 +0200")
Andi Kleen <ak@suse.de> writes:
> On Tuesday 04 October 2005 17:11, Eric W. Biederman wrote:
>> By using a late_initcall as i386 does we don't need to call
>> check_nmi_watchdog manually after SMP startup, and we don't
>> need different code paths for SMP and non SMP.
>>
>> This paves the way for moving apic initialization into init_IRQ,
>> where it belongs.
>
> I don't like it. I want to see a clear message in the log when
> the NMI watchdog doesn't work and with your patch that comes too late.
Why is it to late?
> -Andi (who has rejected similar patches before)
Would it be more appropriate to make this a per cpu check?
I am just trying to make the code path clean so we don't have
special SMP/non-SMP logic. Anything that achieves that is
fine with me.
Eric
next prev parent reply other threads:[~2005-10-04 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-04 15:11 Eric W. Biederman
2005-10-04 15:21 ` Andi Kleen
2005-10-04 15:26 ` Eric W. Biederman [this message]
2005-10-04 15:32 ` Andi Kleen
2005-10-04 16:01 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1y859716y.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=fastboot@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®