From: ebiederm@xmission.com (Eric W. Biederman)
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix voyager compile after machine_emergency_restart breakage
Date: Sat, 06 Aug 2005 10:58:47 -0600 [thread overview]
Message-ID: <m1y87fxarc.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <1123197649.5026.81.camel@mulgrave> (James Bottomley's message of "Thu, 04 Aug 2005 18:20:49 -0500")
James Bottomley <James.Bottomley@SteelEye.com> writes:
> [PATCH] i386: Implement machine_emergency_reboot
>
> introduced this new function into arch/i386/reboot.c. However,
> subarchitectures are entitled to implement their own copies of reboot.c
> from which this new function is now missing.
>
> It looks like visws will also need a similar fixup
Yes, except it looks like it can benefit from a real
machine_emergency_restart, if the smp_send_stop in
there is the one I am familiar with.
My apologies I am always finding the subarchitecture support
on x86 non-intuitive. When you are looking at the primary
code path there is nothing to indicate that there is
a secondary code path out in the machine specific files.
Most other architectures have a machine vector so
you can compile for multiple subarchitectures simultaneously
and then switch between them, at run time. With an optimization
that if you only compile for one subarchitecture the indirect
function call overhead disappears.
Anyway I will see about generating the trivial patch later today.
Eric
next prev parent reply other threads:[~2005-08-06 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-04 23:20 James Bottomley
2005-08-06 16:58 ` Eric W. Biederman [this message]
2005-08-06 19:42 ` [PATCH] i386 voyager: Add machine_shutdown Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1y87fxarc.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®