From: ebiederm@xmission.com (Eric W. Biederman)
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Davide Libenzi <davidel@xmailserver.org>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Robin Holt <holt@sgi.com>, Roland McGrath <roland@redhat.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Gautham R Shenoy <ego@in.ibm.com>
Subject: Re: [PATCH] kthread: Don't depend on work queues (take 2)
Date: Wed, 11 Apr 2007 14:02:24 -0600 [thread overview]
Message-ID: <m1zm5er86n.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20070411194921.GA171@tv-sign.ru> (Oleg Nesterov's message of "Wed, 11 Apr 2007 23:49:21 +0400")
Oleg Nesterov <oleg@tv-sign.ru> writes:
> Ah yes, we still need to export kthreadd_task... I just worried about subtle
> dependency this patch adds... This "kthreadd_task = find_task_by_pid" assumes
> that init/main.c:init() takes lock_kernel() before the first kthread_create().
There is a small element of that. Mostly it assumes we are running in the idle
thread until we call schedule. Anyway the assumption and the code is out
there in the open in the main code path so it is easy to find, and the code works
today.
At this point I am queuing up patches that kill daemonize. I will be
happy to revisit this part once daemonize is gone and the only interesting
file is kthread.c
Eric
next prev parent reply other threads:[~2007-04-11 20:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-10 18:51 [PATCH 2/3] make kernel threads invisible to /sbin/init Oleg Nesterov
2007-04-10 23:16 ` Serge E. Hallyn
2007-04-11 3:29 ` Eric W. Biederman
2007-04-11 3:56 ` Eric W. Biederman
2007-04-11 11:42 ` Oleg Nesterov
2007-04-11 5:44 ` [PATCH] kthread: Don't depend on work queues Eric W. Biederman
2007-04-11 7:03 ` Andrew Morton
2007-04-11 10:13 ` Rafael J. Wysocki
2007-04-11 11:21 ` Gautham R Shenoy
2007-04-11 11:48 ` Oleg Nesterov
2007-04-11 13:31 ` Gautham R Shenoy
2007-04-11 14:36 ` Oleg Nesterov
2007-04-11 19:37 ` Rafael J. Wysocki
2007-04-11 14:44 ` Rafael J. Wysocki
2007-04-11 18:22 ` Eric W. Biederman
2007-04-11 18:27 ` [PATCH] kthread: Don't depend on work queues (take 2) Eric W. Biederman
2007-04-11 18:49 ` [PATCH] Change reparent_to_init to reparent_to_kthreadd Eric W. Biederman
2007-04-11 19:21 ` [PATCH] kthread: Don't depend on work queues (take 2) Andrew Morton
2007-04-11 19:28 ` Oleg Nesterov
2007-04-11 19:40 ` Eric W. Biederman
2007-04-11 19:49 ` Oleg Nesterov
2007-04-11 20:02 ` Eric W. Biederman [this message]
2007-04-11 12:04 ` [PATCH] kthread: Don't depend on work queues Oleg Nesterov
2007-04-11 16:25 ` Eric W. Biederman
2007-04-11 13:15 ` Oleg Nesterov
2007-04-11 16:22 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1zm5er86n.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=davidel@xmailserver.org \
--cc=ego@in.ibm.com \
--cc=holt@sgi.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=rjw@sisk.pl \
--cc=roland@redhat.com \
--cc=serge@hallyn.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®