mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Linus Torvalds <torvalds@osdl.org>
Cc: <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>,
	Andi Kleen <ak@suse.de>,
	alan@redhat.com, Russell King <rmk+lkml@arm.linux.org.uk>,
	Jakub Jelinek <jakub@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Albert Cahalan <acahalan@gmail.com>,
	Bill Nottingham <notting@redhat.com>,
	Marco Roeland <marco.roeland@xs4all.nl>,
	Michael Kerrisk <mtk-manpages@gmx.net>
Subject: [PATCH] sysctl: Undeprecate sys_sysctl
Date: Wed, 08 Nov 2006 12:00:10 -0700	[thread overview]
Message-ID: <m1zmb13gsl.fsf@ebiederm.dsl.xmission.com> (raw)


The basic issue is that despite have been deprecated and warned about
as a very bad thing in the man pages since its inception there are a
few real users of sys_sysctl.  It was my assumption that because
sysctl had been deprecated for all of 2.6 there would be no user space
users by this point, so I initially gave sys_sysctl a very short
deprecation period.

Now that I know there are a few real users the only sane way to
proceed with deprecation is to push the time limit out to a year or
two work and work with distributions that have big testing pools like
fedora core to find these last remaining users.

Which means that the sys_sysctl interface needs to be maintained in
the meantime. 

Since I have provided a technical measure that allows us to add new
sysctl entries without reserving more binary numbers I believe that is
enough to fix the sys_sysctl binary interface maintenance problems,
because there is no longer a need to change the binary interface at
all.

Since the sys_sysctl implementation needs to stay around for a while
and the worst of the maintenance issues that caused us to occasionally
break the ABI have been addressed I don't see any advantage in
continuing with the removal of sys_sysctl.

So instead of merely increasing the deprecation period this patch
removes the deprecation of sys_sysctl and modifies the kernel to
compile the code in by default.

With committing to maintain sys_sysctl we get all of the advantages of
a fast interface for anything that needs it.  Currently sys_sysctl is
about 5x faster than /proc/sys, for the same string data.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 Documentation/feature-removal-schedule.txt |   12 ------------
 init/Kconfig                               |    2 +-
 2 files changed, 1 insertions(+), 13 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 1ac3c74..d52c4aa 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -53,18 +53,6 @@ Who:	Mauro Carvalho Chehab <mchehab@brtu
 
 ---------------------------
 
-What:	sys_sysctl
-When:	January 2007
-Why:	The same information is available through /proc/sys and that is the
-	interface user space prefers to use. And there do not appear to be
-	any existing user in user space of sys_sysctl.  The additional
-	maintenance overhead of keeping a set of binary names gets
-	in the way of doing a good job of maintaining this interface.
-
-Who:	Eric Biederman <ebiederm@xmission.com>
-
----------------------------
-
 What:	PCMCIA control ioctl (needed for pcmcia-cs [cardmgr, cardctl])
 When:	November 2005
 Files:	drivers/pcmcia/: pcmcia_ioctl.c
diff --git a/init/Kconfig b/init/Kconfig
index c8b2624..e85e554 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -304,7 +304,7 @@ config UID16
 
 config SYSCTL_SYSCALL
 	bool "Sysctl syscall support" if EMBEDDED
-	default n
+	default y
 	select SYSCTL
 	---help---
 	  Enable the deprecated sysctl system call.  sys_sysctl uses
-- 
1.4.2.rc3.g7e18e-dirty


             reply	other threads:[~2006-11-08 19:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-08 19:00 Eric W. Biederman [this message]
2006-11-08 19:10 ` Jesper Juhl
2006-11-08 19:58   ` [PATCH] sysctl: Undeprecate sys_sysctl (take 2) Eric W. Biederman
2006-11-10  6:50     ` Andi Kleen
2006-11-10  7:28       ` Eric W. Biederman
2006-11-11  5:27         ` H. Peter Anvin
2006-11-08 20:49 ` [PATCH] sysctl: Undeprecate sys_sysctl Alan Cox
2006-11-08 20:55   ` Arjan van de Ven
2006-11-09 17:27   ` H. Peter Anvin
2006-11-09 23:17 ` Alistair John Strachan
2006-11-10  5:21   ` Eric W. Biederman
2006-11-10  7:56     ` Russell King
2006-11-10  8:13       ` Eric W. Biederman
2006-11-11  8:04         ` Russell King
2006-11-10  8:50     ` Alistair John Strachan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1zmb13gsl.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=acahalan@gmail.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=alan@redhat.com \
    --cc=efault@gmx.de \
    --cc=jakub@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.roeland@xs4all.nl \
    --cc=mtk-manpages@gmx.net \
    --cc=notting@redhat.com \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome