From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751222AbdARW1Z (ORCPT ); Wed, 18 Jan 2017 17:27:25 -0500 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33510 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbdARW1V (ORCPT ); Wed, 18 Jan 2017 17:27:21 -0500 From: Kevin Hilman To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: linux-amlogic@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, Will Deacon , linux-kernel@vger.kernel.org, Rob Herring , Catalin Marinas , Carlo Caione , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Organization: BayLibre References: <20170117030611.23827-1-afaerber@suse.de> <20170117030611.23827-2-afaerber@suse.de> <3005a457-b7cf-393b-42ff-4149e080321c@suse.de> Date: Wed, 18 Jan 2017 14:27:19 -0800 In-Reply-To: <3005a457-b7cf-393b-42ff-4149e080321c@suse.de> ("Andreas =?utf-8?Q?F=C3=A4rber=22's?= message of "Wed, 18 Jan 2017 00:06:07 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0IMRWnb023016 Andreas Färber writes: > Am 17.01.2017 um 04:06 schrieb Andreas Färber: >> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile >> index 0d7bfbf7d922..66bc809a5eae 100644 >> --- a/arch/arm64/boot/dts/amlogic/Makefile >> +++ b/arch/arm64/boot/dts/amlogic/Makefile >> @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-nexbox-a95x.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-s912-q200.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-s912-q201.dtb >> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb > > What is the logic behind meson-gxm-s912-q201 vs. meson-gxm-nexbox-a1? > Should it be renamed to include -s912 for consistency? Oops, I think it should be renamed for consistency. I believe there's only one chip in the GXM family (S912) so it might be that we could either drop the -s912 from the q20x boards or, add it to the nexbox. I lean towards dropping the -s912 since there's a single chip in GXM. (FWIW, GXL has more than one chip in the family so we added the chip there.) >> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-rbox-pro.dtb > > Should this new board use meson-gxm-s912-? No. Unless Neil or you thing otherwise, I think we should send a patch to drop the -s912 from the q20x boards instead. (where "we" == Neil) ;) Kevin